Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2171173002: Renamed attach to attachLayoutTree in comment missed in 2167063002. (Closed)

Created:
4 years, 5 months ago by Bugs Nash
Modified:
4 years, 5 months ago
Reviewers:
nainar, esprehn
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed attach to attachLayoutTree in comment missed in 2167063002. Committed: https://crrev.com/48d3ed9d9a041afced85207ee632af889a1fdd5a Cr-Commit-Position: refs/heads/master@{#407115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bugs Nash
Sorry! So annoying I missed this one more - my original regex assumed there would ...
4 years, 5 months ago (2016-07-22 06:15:20 UTC) #2
esprehn
lgtm
4 years, 5 months ago (2016-07-22 06:58:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171173002/1
4 years, 5 months ago (2016-07-22 07:05:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 09:51:39 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 09:53:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/48d3ed9d9a041afced85207ee632af889a1fdd5a
Cr-Commit-Position: refs/heads/master@{#407115}

Powered by Google App Engine
This is Rietveld 408576698