Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: src/core/SkFontStyle.cpp

Issue 2171163002: Add test for typeface style round trip. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Work around Mac for now. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/core/SkFontStyle.cpp
diff --git a/src/core/SkFontStyle.cpp b/src/core/SkFontStyle.cpp
index 01628ae9d9d4ccdceb774ec31ab591f53cb7d9f6..c6de81885fc9222cf49166b34e964e552df83003 100644
--- a/src/core/SkFontStyle.cpp
+++ b/src/core/SkFontStyle.cpp
@@ -18,7 +18,7 @@ SkFontStyle::SkFontStyle() {
SkFontStyle::SkFontStyle(int weight, int width, Slant slant) {
fUnion.fU32 = 0;
- fUnion.fR.fWeight = SkTPin<int>(weight, kThin_Weight, kBlack_Weight);
+ fUnion.fR.fWeight = SkTPin<int>(weight, 0, 1000);
reed1 2016/07/25 16:48:50 expose as kMin_Weight and kMax_Weight ?
bungeman-skia 2016/07/25 21:03:58 For 1000 it seems best to use kExtraBlack_Weight.
fUnion.fR.fWidth = SkTPin<int>(width, kUltraCondensed_Width, kUltaExpanded_Width);
fUnion.fR.fSlant = SkTPin<int>(slant, kUpright_Slant, kOblique_Slant);
}

Powered by Google App Engine
This is Rietveld 408576698