src/ports/SkFontHost_FreeType.cpp - Issue 2171163002: Add test for typeface style round trip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_FreeType.cpp

Issue 2171163002: Add test for typeface style round trip. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Name extremes, add comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_FreeType.cpp

diff --git a/src/ports/SkFontHost_FreeType.cpp b/src/ports/SkFontHost_FreeType.cpp

index 4a1f12babe2adc07a876657ddfb9e5c1a5c17cf2..e093bf04e701ad8dd028c0078c03b308157e8b56 100644

--- a/src/ports/SkFontHost_FreeType.cpp

+++ b/src/ports/SkFontHost_FreeType.cpp

@@ -1696,9 +1696,9 @@ bool SkTypeface_FreeType::Scanner::scanFont(

{ "standard", SkFontStyle::kNormal_Weight },

{ "thin", SkFontStyle::kThin_Weight },

{ "ultra", SkFontStyle::kExtraBold_Weight },

- { "ultrablack", 1000 },

+ { "ultrablack", SkFontStyle::kExtraBlack_Weight },

{ "ultrabold", SkFontStyle::kExtraBold_Weight },

- { "ultraheavy", 1000 },

+ { "ultraheavy", SkFontStyle::kExtraBlack_Weight },

{ "ultralight", SkFontStyle::kExtraLight_Weight },

};

int const index = SkStrLCSearch(&commonWeights[0].name, SK_ARRAY_COUNT(commonWeights),

« no previous file with comments | « src/ports/SkFontConfigInterface_direct.cpp ('k') | src/ports/SkFontHost_mac.cpp » ('j') | no next file with comments »