Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2171133003: macOS: Respect more CSS properties for menulist SELECT elements. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

macOS: Respect more CSS properties for menulist SELECT elements. -webkit-appearance:menulist, which is the default appearance of menulist SELECT, uses fixed font sizes, auto height, and the fixed font family. Ignoring such style was not good for platform-predictability. After this CL, -webkit-appearance:menulist automatically fallbacks to -webkit-appearnce:menulist-button by font-size, height, font-family CSS properties. This CL also changes the default rendering of <input type=color list> because it uses -webkit-appearance:menulist with a fixed height. The new rendering is better because its height is same as the default rendering of <input type=color>. BUG=104922 Committed: https://crrev.com/b856aa2c66ff2cea4af05ecd4eb6fb5c56a91129 Cr-Commit-Position: refs/heads/master@{#407105}

Patch Set 1 #

Patch Set 2 : Rebaseline more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -173 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/percent-height-auto-width-form-controls.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt View 3 chunks +27 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/basic-selects-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/basic-selects-expected.txt View 2 chunks +60 lines, -60 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-basic-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-appearance-basic-expected.txt View 6 chunks +71 lines, -71 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-no-overflow-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-no-overflow-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/forms/select/menulist-popup-item-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 2 chunks +32 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
tkent
Keishi, would you review this please?
4 years, 5 months ago (2016-07-22 06:18:03 UTC) #5
keishi
LGTM
4 years, 5 months ago (2016-07-22 06:44:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171133003/20001
4 years, 5 months ago (2016-07-22 08:47:50 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 08:52:08 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 08:55:14 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b856aa2c66ff2cea4af05ecd4eb6fb5c56a91129
Cr-Commit-Position: refs/heads/master@{#407105}

Powered by Google App Engine
This is Rietveld 408576698