Implement opus seek preroll for MediaSourceExtensions.

media/test/pipeline_integration_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
 #include <utility>
 
@@ skipping 123 matching lines @@
 const int kVP8AWebMFileDurationMs = 2734;
 
 #if !defined(MOJO_RENDERER)
 #if defined(OPUS_FIXED_POINT)
 static const char kOpusEndTrimmingHash_1[] =
     "-4.57,-5.66,-6.52,-6.30,-4.37,-3.61,";
 static const char kOpusEndTrimmingHash_2[] =
     "-11.91,-11.11,-8.27,-7.13,-7.86,-10.00,";
 static const char kOpusEndTrimmingHash_3[] =
     "-13.31,-14.38,-13.70,-11.71,-10.21,-10.49,";
+static const char kOpusSmallCodecDelayHash_1[] =
+    "-0.47,-0.09,1.28,1.07,1.55,-0.22,";

[chcunningham, 2016/12/01 21:12:24]

surprisingly the arm bots didn't fail. not sure if they just don't run this
test. looks like i'll have to build arm and calculate myself .... SELF: don't
forget. 

[wolenetz, 2016/12/02 00:18:49]

I wonder if this is an artifact of OpusAudioDecoder's removal and usage of
FFmpegAudioDecoder + ffmpeg + third_party/opus to accomplish the decodes (ffmpeg
M56 roll + https://codereview.chromium.org/2435603009/): You might check to see
if OPUS_FIXED_POINT is never defined here now on any arm build.

[wolenetz, 2016/12/02 00:41:04]

Oh - android doesn't run pipeline_integration_tests, apparently (at least,
without mojo, and with mojo, clockless is disabled so the new tests using these
hashes are disabled). See
https://cs.chromium.org/chromium/src/media/test/BUILD.gn?rcl=0&l=57 (and watk@,
I guess).

Maybe an arm cros run might help. lack of pipeline_integration_tests on android
is a bit concerning though.

+static const char kOpusSmallCodecDelayHash_2[] =
+    "0.31,0.15,-0.18,0.25,0.70,0.84,";
 #else
 // Hash for a full playthrough of "opus-trimming-test.(webm|ogg)".
 static const char kOpusEndTrimmingHash_1[] =
     "-4.56,-5.65,-6.51,-6.29,-4.36,-3.59,";
 // The above hash, plus an additional playthrough starting from T=1s.
 static const char kOpusEndTrimmingHash_2[] =
     "-11.89,-11.09,-8.25,-7.11,-7.84,-9.97,";
 // The above hash, plus an additional playthrough starting from T=6.36s.
 static const char kOpusEndTrimmingHash_3[] =
     "-13.28,-14.35,-13.67,-11.68,-10.18,-10.46,";
+// Hash for a full playthrough of "bear-opus.webm".
+static const char kOpusSmallCodecDelayHash_1[] =
+    "-0.47,-0.09,1.28,1.07,1.55,-0.22,";
+// The above hash, plus an additional plathrough starting from T=1.414s.

[wolenetz, 2016/12/02 00:18:50]

nit: plathrough

[chcunningham, 2016/12/02 21:41:09]

Done.

+static const char kOpusSmallCodecDelayHash_2[] =
+    "0.31,0.15,-0.18,0.25,0.70,0.84,";
 #endif  // defined(OPUS_FIXED_POINT)
 #endif  // !defined(MOJO_RENDERER)
 
 #if defined(USE_PROPRIETARY_CODECS)
 const int k640IsoFileDurationMs = 2737;
 const int k640IsoCencFileDurationMs = 2736;
 const int k1280IsoFileDurationMs = 2736;
 const int k1280IsoAVC3FileDurationMs = 2736;
 #endif  // defined(USE_PROPRIETARY_CODECS)
 
@@ skipping 979 matching lines @@
   // Seek somewhere outside of the pre-skip / end-trim section, demuxer should
   // correctly preroll enough to accurately decode this segment.
   seek_time = base::TimeDelta::FromMilliseconds(6360);
   source.Seek(seek_time);
   ASSERT_TRUE(Seek(seek_time));
   Play();
   ASSERT_TRUE(WaitUntilOnEnded());
   EXPECT_HASH_EQ(kOpusEndTrimmingHash_3, GetAudioHash());
 }
 
-// TODO(dalecurtis): Add an opus test file which FFmpeg and ChunkDemuxer will
-// both seek the same in and shows the difference of preroll.
-// http://crbug.com/509894
+TEST_F(PipelineIntegrationTest,
+       MAYBE_CLOCKLESS(BasicPlaybackOpusPrerollExceedsCodecDelay)) {
+  ASSERT_EQ(PIPELINE_OK, Start("bear-opus.webm", kHashed | kClockless));
+
+  AudioDecoderConfig config =
+      demuxer_->GetStream(DemuxerStream::AUDIO)->audio_decoder_config();
+
+  // Verify that this file's preroll is not eclipsed by the codec delay so we
+  // can detect when preroll is not properly performed.
+  base::TimeDelta codec_delay = base::TimeDelta::FromSecondsD(
+      static_cast<double>(config.codec_delay()) / config.samples_per_second());
+  ASSERT_GT(config.seek_preroll(), codec_delay);
+
+  Play();
+  ASSERT_TRUE(WaitUntilOnEnded());
+  EXPECT_HASH_EQ(kOpusSmallCodecDelayHash_1, GetAudioHash());
+
+  // Seek halfway through the file to invoke seek preroll.
+  ASSERT_TRUE(Seek(base::TimeDelta::FromSecondsD(1.414)));
+  Play();
+  ASSERT_TRUE(WaitUntilOnEnded());
+  EXPECT_HASH_EQ(kOpusSmallCodecDelayHash_2, GetAudioHash());
+}
+
+TEST_F(PipelineIntegrationTest,
+       MAYBE_CLOCKLESS(BasicPlaybackOpusPrerollExceedsCodecDelay_MediaSource)) {
+  MockMediaSource source("bear-opus.webm", kOpusAudioOnlyWebM,
+                         kAppendWholeFile);
+  EXPECT_EQ(PIPELINE_OK, StartPipelineWithMediaSource(
+                             &source, kClockless | kHashed, nullptr));
+  source.EndOfStream();
+
+  AudioDecoderConfig config =
+      demuxer_->GetStream(DemuxerStream::AUDIO)->audio_decoder_config();
+
+  // Verify that this file's preroll is not eclipsed by the codec delay so we
+  // can detect when preroll is not properly performed.
+  base::TimeDelta codec_delay = base::TimeDelta::FromSecondsD(
+      static_cast<double>(config.codec_delay()) / config.samples_per_second());
+  ASSERT_GT(config.seek_preroll(), codec_delay);
+
+  Play();
+  ASSERT_TRUE(WaitUntilOnEnded());
+  EXPECT_HASH_EQ(kOpusSmallCodecDelayHash_1, GetAudioHash());
+
+  // Seek halfway through the file to invoke seek preroll.
+  base::TimeDelta seek_time = base::TimeDelta::FromSecondsD(1.414);
+  source.Seek(seek_time);
+  ASSERT_TRUE(Seek(seek_time));
+  Play();
+  ASSERT_TRUE(WaitUntilOnEnded());
+  EXPECT_HASH_EQ(kOpusSmallCodecDelayHash_2, GetAudioHash());
+}
 
 TEST_F(PipelineIntegrationTest, BasicPlaybackLive) {
   ASSERT_EQ(PIPELINE_OK, Start("bear-320x240-live.webm", kHashed));
 
   // Live stream does not have duration in the initialization segment.
   // It will be set after the entire file is available.
   EXPECT_CALL(*this, OnDurationChange()).Times(1);
 
   Play();
 
@@ skipping 1342 matching lines @@
 
 TEST_F(PipelineIntegrationTest, BasicPlaybackPositiveStartTime) {
   ASSERT_EQ(PIPELINE_OK, Start("nonzero-start-time.webm"));
   Play();
   ASSERT_TRUE(WaitUntilOnEnded());
   ASSERT_EQ(base::TimeDelta::FromMicroseconds(396000),
             demuxer_->GetStartTime());
 }
 
 }  // namespace media