Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2171123002: chrome/browser/memory: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
chrisha
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/memory: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=chrisha@chromium.org BUG=554600 Committed: https://crrev.com/0b93e11fe659a7d3e68bdc318f4d0ec1eef69ad4 Cr-Commit-Position: refs/heads/master@{#407591}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/memory/tab_manager.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/memory/tab_manager_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/memory/tab_manager_observer_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory/tab_manager_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/memory/tab_manager_web_contents_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-22 00:49:13 UTC) #1
chrisha
Thanks for the cleanup. lgtm!
4 years, 5 months ago (2016-07-22 19:57:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171123002/20001
4 years, 5 months ago (2016-07-25 21:02:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-25 21:41:27 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:43:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b93e11fe659a7d3e68bdc318f4d0ec1eef69ad4
Cr-Commit-Position: refs/heads/master@{#407591}

Powered by Google App Engine
This is Rietveld 408576698