chrome/browser/ui/views/chooser_content_view.h - Issue 2171103002: Add test for WebBluetooth chooser spinner, status text and rescan button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chooser_content_view.h

Issue 2171103002: Add test for WebBluetooth chooser spinner, status text and rescan button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed chooser_dialog_view_browsertest.cc to chooser_dialog_view_unittest.cc Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chooser_controller/mock_chooser_controller.cc ('k') | chrome/browser/ui/views/chooser_content_view.cc » ('j') | chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/chooser_content_view.h

diff --git a/chrome/browser/ui/views/chooser_content_view.h b/chrome/browser/ui/views/chooser_content_view.h

index 59671f99c0cb64a3be84151bd36bf48567a25b64..8d2016a53b57e6a4b71e62cfc5215bd1a20ccbd5 100644

--- a/chrome/browser/ui/views/chooser_content_view.h

+++ b/chrome/browser/ui/views/chooser_content_view.h

@@ -62,7 +62,7 @@ class ChooserContentView : public views::View,

base::string16 GetDialogButtonLabel(ui::DialogButton button) const;

bool IsDialogButtonEnabled(ui::DialogButton button) const;

// Ownership of the view is passed to the caller.

- views::View* CreateExtraView();

+ views::Link* CreateExtraView();

// Ownership of the view is passed to the caller.

views::StyledLabel* CreateFootnoteView();

void Accept();

@@ -71,7 +71,7 @@ class ChooserContentView : public views::View,

void UpdateTableView();

views::TableView* table_view_for_test() const { return table_view_; }

- views::StyledLabel* styled_label_for_test() const { return styled_label_; }

+ views::Throbber* throbber_for_test() const { return throbber_; }

private:

std::unique_ptr<ChooserController> chooser_controller_;