Switch ChromeDriver builders from GYP to GN.

Switch ChromeDriver builders from GYP to GN.

BUG=chromedriver:1384
Committed: https://chromium.googlesource.com/chromium/tools/build/+/8d853db2fb3fa95a4b3be09057e1256092765de7

[samuong, 2016-07-21 23:37:13]

samuong@chromium.org changed reviewers:
+ jbudorick@chromium.org

[samuong, 2016-07-21 23:37:14]

This CL depends on https://codereview.chromium.org/2170163002/.

I've only done the Linux32 config for now, but if this looks right to you I'll
go and update the other three desktop bots before landing this. They'll all be
the same, except we won't strip on Windows.

[jbudorick, 2016-07-22 00:45:01]

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py (right):

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:62:
api.python("meta build", api.path["checkout"].join("tools", "mb", "mb.py",
This should be:

  api.python('meta build', api.path['checkout'].join('tools', 'mb', 'mb.py'),
args=['gen', '-m', ...])

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:69:
api.m.step('strip', cmd=['strip', str(api.path['checkout'].join(
What's with the strip step?

[samuong, 2016-07-22 02:49:13]

I've done the other 3 bots as well.

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py (right):

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:62:
api.python("meta build", api.path["checkout"].join("tools", "mb", "mb.py",
On 2016/07/22 00:45:01, jbudorick wrote:
> This should be:
> 
>   api.python('meta build', api.path['checkout'].join('tools', 'mb', 'mb.py'),
> args=['gen', '-m', ...])

Done.

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:69:
api.m.step('strip', cmd=['strip', str(api.path['checkout'].join(
On 2016/07/22 00:45:01, jbudorick wrote:
> What's with the strip step?

I'm seeing very large (144M) binaries when I build with GN. After we strip, this
goes down to ~7M. There's a bit more context at
https://bugs.chromium.org/p/chromedriver/issues/detail?id=1384.

[jbudorick, 2016-07-22 02:58:31]

lgtm

I had formatting nits, but this entire file is formatted somewhat
idiosyncratically and it's going away soon.

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py (right):

https://codereview.chromium.org/2171093002/diff/40001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:69:
api.m.step('strip', cmd=['strip', str(api.path['checkout'].join(
On 2016/07/22 02:49:12, samuong wrote:
> On 2016/07/22 00:45:01, jbudorick wrote:
> > What's with the strip step?
> 
> I'm seeing very large (144M) binaries when I build with GN. After we strip,
this
> goes down to ~7M. There's a bit more context at
> https://bugs.chromium.org/p/chromedriver/issues/detail?id=1384.

That's what I get for not reading that bug closely enough. SGTM.

https://codereview.chromium.org/2171093002/diff/60001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py (right):

https://codereview.chromium.org/2171093002/diff/60001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:63: args=["gen",
"-m", "chromium.chromedriver", "-b", "Linux32",
I guess this is ok in the short term, but it should be
build_properties.get('buildername') rather than "Linux32".

[samuong, 2016-07-22 03:52:22]

https://codereview.chromium.org/2171093002/diff/60001/scripts/slave/recipes/c...
File scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py (right):

https://codereview.chromium.org/2171093002/diff/60001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.chromedriver.recipe_autogen.py:63: args=["gen",
"-m", "chromium.chromedriver", "-b", "Linux32",
On 2016/07/22 02:58:31, jbudorick wrote:
> I guess this is ok in the short term, but it should be
> build_properties.get('buildername') rather than "Linux32".

Done.

[jbudorick, 2016-07-22 15:53:08]

lgtm

[samuong, 2016-07-22 17:11:20]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:11:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:13:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:13:20]

Try jobs failed on following builders:
  Build Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[samuong, 2016-07-22 18:36:36]

The CQ bit was checked by samuong@chromium.org

[samuong, 2016-07-22 18:36:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2171093002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-22 18:36:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 18:41:00]

Description was changed from

==========
Switch ChromeDriver builders from GYP to GN.

BUG=chromedriver:1384
==========

to

==========
Switch ChromeDriver builders from GYP to GN.

BUG=chromedriver:1384

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/8d853db2fb3fa95a4b3b...
==========

[commit-bot: I haz the power, 2016-07-22 18:41:01]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/tools/build/+/8d853db2fb3fa95a4b3b...