third_party/WebKit/Source/core/loader/FrameLoaderClient.h - Issue 2171063002: Notify the Blink client synchronously if the initial doc is accessed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoaderClient.h

Issue 2171063002: Notify the Blink client synchronously if the initial doc is accessed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Forbid scripts. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/loader/FrameLoader.cpp ('K') | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoaderClient.h

diff --git a/third_party/WebKit/Source/core/loader/FrameLoaderClient.h b/third_party/WebKit/Source/core/loader/FrameLoaderClient.h

index e320cddb7837dc044f483970dc2a1f81f1f0f9ee..26cfec4be4c7655e34bf50e9c1f34e127db32fbe 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoaderClient.h

+++ b/third_party/WebKit/Source/core/loader/FrameLoaderClient.h

@@ -124,7 +124,8 @@ public:

// Another page has accessed the initial empty document of this frame.

// It is no longer safe to display a provisional URL, since a URL spoof

- // is now possible.

+ // is now possible. The client must not call back into JavaScript during

+ // this notification.

dcheng 2016/07/22 06:22:03 It makes me sad that this comment is necessary, si

Charlie Reis 2016/07/22 16:41:44 Yeah, I added it before we had the ScriptForbidden

virtual void didAccessInitialDocument() { }

dglazkov 2016/07/22 14:32:10 The only user of this is RenderFrameImpl::didAcces

Charlie Reis 2016/07/22 16:41:43 That's right. That's the only use, and there's no

// This frame has displayed inactive content (such as an image) from an