Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 2171023002: Revert of Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS (Closed)

Created:
4 years, 5 months ago by Jamie Madill
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, derat+watch_chromium.org, piman+watch_chromium.org, ppc1_chromium.org, sadrul, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS (patchset #17 id:310001 of https://codereview.chromium.org/2124633002/ ) Reason for revert: Seems to break the Android and Linux GPU fyi bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205X%29/builds/1098 https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48671 https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%206P%29/builds/1004 <couple others> GpuProcess.no_transparent_visuals_gpu_process Failure: disable_transparent_visuals is missing in Browser process workarounds: [u'broken_egl_image_ref_counting', u'clear_uniforms_before_first_program_use', u'disable_blend_equation_advanced', u'disable_chromium_framebuffer_multisample', u'disable_depth_texture', u'disable_discard_framebuffer', u'disable_framebuffer_cmaa', u'disable_program_cache', u'force_cube_map_positive_x_allocation', u'max_copy_texture_chromium_size_1048576', u'max_texture_size_limit_4096', u'scalarize_vec_and_mat_constructor_args', u'unbind_attachments_on_bound_render_fbo_delete', u'unbind_egl_context_to_flush_driver_caches', u'use_virtualized_gl_contexts', u'wake_up_gpu_before_drawing'] [ FAILED ] GpuProcess.no_transparent_visuals_gpu_process (5860 ms) Original issue's description: > Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS > > This is for better polish in the UI but it fixes a drag > image issue on Linux crbug.com/593256 . > > Also add a kGpuDriverBugListJson entry to automatically > disable transparent visuals on all drivers (especially > the proprietary NVIDIA driver) except for opensource > drivers (i.e. Mesa based drivers). > > BUG=369209 > > R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 > Cr-Commit-Position: refs/heads/master@{#406505} TBR=kbr@chromium.org,sadrul@chromium.org,tapted@chromium.org,piman@chromium.org,j.isorce@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=369209 Committed: https://crrev.com/096fa27cc41bc2578e5787ea5828255542c169f2 Cr-Commit-Position: refs/heads/master@{#407047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -127 lines) Patch
M content/browser/browser_main_loop.cc View 3 chunks +14 lines, -17 lines 0 comments Download
M content/test/gpu/page_sets/gpu_process_tests.py View 2 chunks +0 lines, -52 lines 0 comments Download
M extensions/browser/api/app_window/app_window_apitest.cc View 3 chunks +6 lines, -21 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +1 line, -17 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/x/x11_util.cc View 4 chunks +14 lines, -4 lines 0 comments Download
M ui/base/x/x11_util_internal.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gfx/x/x11_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/x/x11_switches.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jamie Madill
Created Revert of Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS
4 years, 5 months ago (2016-07-21 22:28:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171023002/1
4 years, 5 months ago (2016-07-21 22:29:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 03:50:59 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:54:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/096fa27cc41bc2578e5787ea5828255542c169f2
Cr-Commit-Position: refs/heads/master@{#407047}

Powered by Google App Engine
This is Rietveld 408576698