third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js - Issue 2170993002: Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

Issue 2170993002: Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/components/minimum-size.html ('k') | third_party/WebKit/Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

index c9aa41c769f2ad0bd16b86b0982781a214ef40be..8a84df6ed782ecd1eadf0842e89f4e5545b51575 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js

@@ -249,7 +249,7 @@

delete this._objectPropertiesView;

}

if (this._extensionView)

- this._extensionView.detach();

+ this._extensionView.detach(true);

this._extensionView = new WebInspector.ExtensionView(this._server, this._id, url, "extension fill");

this._extensionView.show(this.element);

@@ -286,7 +286,7 @@

if (this._objectPropertiesView)

return;

if (this._extensionView) {

- this._extensionView.detach();

+ this._extensionView.detach(true);

delete this._extensionView;

}

this._objectPropertiesView = new WebInspector.ExtensionNotifierView(this._server, this._id);