Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 2170993002: Revert of DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 this._restoreTabIndexOnElements(); 102 this._restoreTabIndexOnElements();
103 103
104 delete WebInspector.Dialog._instance; 104 delete WebInspector.Dialog._instance;
105 }, 105 },
106 106
107 addCloseButton: function() 107 addCloseButton: function()
108 { 108 {
109 var closeButton = this.contentElement.createChild("div", "dialog-close-b utton", "dt-close-button"); 109 var closeButton = this.contentElement.createChild("div", "dialog-close-b utton", "dt-close-button");
110 closeButton.gray = true; 110 closeButton.gray = true;
111 closeButton.addEventListener("click", this.detach.bind(this), false); 111 closeButton.addEventListener("click", this.detach.bind(this, false), fal se);
112 }, 112 },
113 113
114 /** 114 /**
115 * @param {number=} positionX 115 * @param {number=} positionX
116 * @param {number=} positionY 116 * @param {number=} positionY
117 */ 117 */
118 setPosition: function(positionX, positionY) 118 setPosition: function(positionX, positionY)
119 { 119 {
120 this._defaultPositionX = positionX; 120 this._defaultPositionX = positionX;
121 this._defaultPositionY = positionY; 121 this._defaultPositionY = positionY;
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 { 281 {
282 return WebInspector.Dialog._modalHostView; 282 return WebInspector.Dialog._modalHostView;
283 }; 283 };
284 284
285 WebInspector.Dialog.modalHostRepositioned = function() 285 WebInspector.Dialog.modalHostRepositioned = function()
286 { 286 {
287 if (WebInspector.Dialog._instance) 287 if (WebInspector.Dialog._instance)
288 WebInspector.Dialog._instance._position(); 288 WebInspector.Dialog._instance._position();
289 }; 289 };
290 290
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/RootView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698