Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2170983002: android_webview: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android_webview: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=boliu@chromium.org BUG=554600 Committed: https://crrev.com/038b95619952006436c8feeb058e4ff45f510697 Cr-Commit-Position: refs/heads/master@{#406960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-21 20:57:19 UTC) #2
boliu
lgtm
4 years, 5 months ago (2016-07-21 21:07:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170983002/1
4 years, 5 months ago (2016-07-21 21:11:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 22:04:09 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:05:10 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/038b95619952006436c8feeb058e4ff45f510697
Cr-Commit-Position: refs/heads/master@{#406960}

Powered by Google App Engine
This is Rietveld 408576698