Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2170933002: gpu, cmaa: avoid == for float in GLSL (Closed)

Created:
4 years, 5 months ago by dshwang
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu, cmaa: avoid == for float in GLSL According to the GLSL spec, GLSL float can represent exact integers between 0 and 2048. However, some drivers might not respect the spec. So use uint for == operator. In detail, 1. GLSL uses IEEE 754 float or half float. https://www.opengl.org/wiki/Data_Type_(GLSL)#Scalars 2. IEEE 754 half float preserves integers between 0 and 2048 exactly represented. https://en.wikipedia.org/wiki/Half-precision_floating-point_format#Precision_limitations_on_integer_values BUG=535198 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3b9374a3373f1f29f4f6a6762e1cddc9aec78549 Cr-Commit-Position: refs/heads/master@{#407466}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dshwang
piman@, could you review this simple CL?
4 years, 5 months ago (2016-07-21 17:24:44 UTC) #5
piman
lgtm
4 years, 5 months ago (2016-07-21 17:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170933002/1
4 years, 5 months ago (2016-07-25 12:55:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 13:49:55 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 13:51:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b9374a3373f1f29f4f6a6762e1cddc9aec78549
Cr-Commit-Position: refs/heads/master@{#407466}

Powered by Google App Engine
This is Rietveld 408576698