Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2170923002: Add some missing CrashExitCodes for child processes. (Closed)

Created:
4 years, 5 months ago by Will Harris
Modified:
4 years, 5 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some missing CrashExitCodes for child processes. Also, rename 536870904 to "Out of Memory" since this isn't a real Windows exception code. BUG=614440 Committed: https://crrev.com/f7640b9cc0c85d0c650725d3f496facd18488663 Cr-Commit-Position: refs/heads/master@{#406941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M tools/metrics/histograms/histograms.xml View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Will Harris
PTAL. This adds meaningful codes for any crash exit code seen on Chrome Stable that ...
4 years, 5 months ago (2016-07-21 17:05:31 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 5 months ago (2016-07-21 18:05:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170923002/1
4 years, 5 months ago (2016-07-21 18:11:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 21:15:24 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:17:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7640b9cc0c85d0c650725d3f496facd18488663
Cr-Commit-Position: refs/heads/master@{#406941}

Powered by Google App Engine
This is Rietveld 408576698