Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2170913003: Remove unused methods from JS_Object.cpp (Closed)

Created:
4 years, 5 months ago by Tom Sepez
Modified:
4 years, 5 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M fpdfsdk/javascript/JS_Object.h View 2 chunks +0 lines, -8 lines 0 comments Download
M fpdfsdk/javascript/JS_Object.cpp View 1 chunk +0 lines, -16 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
Tom Sepez
dsinclair, nothing but red.
4 years, 5 months ago (2016-07-21 18:57:15 UTC) #2
dsinclair
lgtm w/ question https://codereview.chromium.org/2170913003/diff/1/fpdfsdk/javascript/JS_Object.cpp File fpdfsdk/javascript/JS_Object.cpp (right): https://codereview.chromium.org/2170913003/diff/1/fpdfsdk/javascript/JS_Object.cpp#newcode15 fpdfsdk/javascript/JS_Object.cpp:15: int FXJS_MsgBox(CPDFDoc_Environment* pApp, Can we move ...
4 years, 5 months ago (2016-07-21 19:00:20 UTC) #5
Tom Sepez
On 2016/07/21 19:00:20, dsinclair wrote: > lgtm w/ question > > https://codereview.chromium.org/2170913003/diff/1/fpdfsdk/javascript/JS_Object.cpp > File fpdfsdk/javascript/JS_Object.cpp ...
4 years, 5 months ago (2016-07-21 19:02:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170913003/1
4 years, 5 months ago (2016-07-21 19:03:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 19:12:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/3999d6a4ec124b2e5f68aadb7b51f387733a...

Powered by Google App Engine
This is Rietveld 408576698