Issue 217083003: Smi immediates are not supported on x64. Do not use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 217083003: Smi immediates are not supported on x64. Do not use it. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Smi immediates are not supported on x64. Do not use it. R=jkummerow@chromium.org BUG=358059 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20409

Patch Set 2 : m8 x64.debug.check #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -17 lines)			Patch
M	src/x64/lithium-codegen-x64.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+11 lines, -6 lines	0 comments	Download
A +	test/mjsunit/regress/regress-358059.js	View		1 chunk	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://codereview.chromium.org/217083003/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): https://codereview.chromium.org/217083003/diff/1/src/x64/lithium-codegen-x64.cc#newcode1823 src/x64/lithium-codegen-x64.cc:1823: ASSERT(!target_rep.IsSmi()); // Not support for smi-immediates. nit: s/Not/No/

6 years, 8 months ago (2014-04-01 15:14:28 UTC) #2

Yang

6 years, 8 months ago (2014-04-01 15:32:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20409 (presubmit successful).

Expand Messages | Collapse Messages

Issue 217083003: Smi immediates are not supported on x64. Do not use it. (Closed)

Description

Patch Set 1 #

Patch Set 2 : m8 x64.debug.check #

Messages