Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2170813003: Convert some component source sets to static library (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some component source sets to static library This is hoping to achieve better build performance. BUG=627637 Committed: https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d Cr-Commit-Position: refs/heads/master@{#407188}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M components/search_provider_logos/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/security_state/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/account_id/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ssl_config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ssl_errors/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/startup_metric_utils/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/subresource_filter/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/subresource_filter/content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/subresource_filter/content/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/subresource_filter/core/common/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/suggestions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/supervised_user_error_page/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/language_detection/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/upload_list/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/url_formatter/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/net/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/service/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/version_info/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/version_ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/visitedlink/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/web_cache/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/web_cache/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/webcrypto/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/wifi/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
brettw
4 years, 5 months ago (2016-07-21 21:55:40 UTC) #2
brettw
fixes
4 years, 5 months ago (2016-07-21 21:56:27 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 22:09:04 UTC) #6
brettw
mac
4 years, 5 months ago (2016-07-21 22:23:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170813003/40001
4 years, 5 months ago (2016-07-21 22:24:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/108467)
4 years, 5 months ago (2016-07-22 01:18:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170813003/40001
4 years, 5 months ago (2016-07-22 16:45:27 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-22 17:24:08 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 17:26:11 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d
Cr-Commit-Position: refs/heads/master@{#407188}

Powered by Google App Engine
This is Rietveld 408576698