Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2170813002: Fix r37816: SloppyBlockFunctionStatement needs to go to parser_zone_. (Closed)

Created:
4 years, 5 months ago by marja
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, titzer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix r37816: SloppyBlockFunctionStatement needs to go to parser_zone_. Putting SloppyBlockFunctionStatement into local_zone_ was too early. It needs to go into parser_zone_ because Scope refers to it. It will be moved back to local_zone_ when we can put Scopes into temporary Zones. A test (to demonstrate we crash without this CL) will follow in a separate CL. R=verwaest@chromium.org BUG= Committed: https://crrev.com/c1da025b031cdd3c0f288b38019a424186182df3 Cr-Commit-Position: refs/heads/master@{#37920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ast/ast.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
marja
verwaest@, ptal titzer@, fyi
4 years, 5 months ago (2016-07-21 06:53:52 UTC) #2
Toon Verwaest
lgtm
4 years, 5 months ago (2016-07-21 06:57:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170813002/1
4 years, 5 months ago (2016-07-21 07:03:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 07:26:15 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 07:27:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1da025b031cdd3c0f288b38019a424186182df3
Cr-Commit-Position: refs/heads/master@{#37920}

Powered by Google App Engine
This is Rietveld 408576698