tools/viewer/ImageSlide.cpp - Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/viewer/ImageSlide.cpp

Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Pass refs more efficiently Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/viewer/ImageSlide.cpp

diff --git a/tools/viewer/ImageSlide.cpp b/tools/viewer/ImageSlide.cpp

index 3ba6b584603064fa9aee965dfd13a038170a64ab..b0471547bcb3180efbd0d2fbac5b52a58cbf39bc 100644

--- a/tools/viewer/ImageSlide.cpp

+++ b/tools/viewer/ImageSlide.cpp

@@ -41,7 +41,7 @@ void ImageSlide::load(SkScalar, SkScalar) {

fImage->asLegacyBitmap(&fOriginalBitmap, SkImage::kRO_LegacyBitmapMode);

SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(encoded.get()));

- sk_sp<SkColorSpace> srcSpace = sk_ref_sp(codec->getColorSpace());

+ sk_sp<SkColorSpace> srcSpace = sk_ref_sp(codec->getInfo().colorSpace());

sk_sp<SkColorSpace> dstSpace = SkColorSpace::NewNamed(SkColorSpace::kAdobeRGB_Named);

std::unique_ptr<SkColorSpaceXform> xform = SkColorSpaceXform::New(srcSpace, dstSpace);

fOriginalBitmap.deepCopyTo(&fXformedBitmap);

« no previous file with comments | « tests/ColorSpaceTest.cpp ('k') | tools/visualize_color_gamut.cpp » ('j') | no next file with comments »