src/codec/SkCodec.cpp - Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec.cpp

Issue 2170793004: Remove unnecessary getColorSpace() API from SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Pass refs more efficiently Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec.cpp

diff --git a/src/codec/SkCodec.cpp b/src/codec/SkCodec.cpp

index 3da7f5fb07bd9f6381417ea904fb67c77a5d69a0..e5f9a07f6bcce9f1f34029a95081ca1009fc0b53 100644

--- a/src/codec/SkCodec.cpp

+++ b/src/codec/SkCodec.cpp

@@ -117,10 +117,9 @@ SkCodec* SkCodec::NewFromData(SkData* data, SkPngChunkReader* reader) {

SkCodec::SkCodec(int width, int height, const SkEncodedInfo& info, SkStream* stream,

sk_sp<SkColorSpace> colorSpace, Origin origin)

: fEncodedInfo(info)

- , fSrcInfo(info.makeImageInfo(width, height, colorSpace))

+ , fSrcInfo(info.makeImageInfo(width, height, std::move(colorSpace)))

, fStream(stream)

, fNeedsRewind(false)

- , fColorSpace(std::move(colorSpace))

, fOrigin(origin)

, fDstInfo()

, fOptions()

« no previous file with comments | « include/codec/SkEncodedInfo.h ('k') | tests/ColorSpaceTest.cpp » ('j') | no next file with comments »