Add Node.getRootNode(options)

Add Node.getRootNode(options)

Intent to Ship and Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MjeLmhOZKXw/zvlyAsvNBAAJ

BUG=629739
Committed: https://crrev.com/9520623861da283533e71d6b7a8babd02675cb0b
Cr-Commit-Position: refs/heads/master@{#407419}

[hayato, 2016-07-21 06:09:42]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 06:10:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 07:25:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 07:25:35]

Dry run: This issue passed the CQ dry run.

[hayato, 2016-07-25 03:41:45]

rebased

[hayato, 2016-07-25 03:41:46]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 03:41:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-25 03:43:58]

Description was changed from

==========
Add Node.getRootNode(options)

BUG=
==========

to

==========
Add Node.getRootNode(options)

Intent to Ship and Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MjeLmhOZKXw

BUG=629739
==========

[hayato, 2016-07-25 03:44:50]

Description was changed from

==========
Add Node.getRootNode(options)

Intent to Ship and Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/MjeLmhOZKXw

BUG=629739
==========

to

==========
Add Node.getRootNode(options)

Intent to Ship and Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MjeLmhOZKXw/zvlyAsvN...

BUG=629739
==========

[hayato, 2016-07-25 03:45:53]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-07-25 03:45:54]

PTAL

[kochi, 2016-07-25 04:48:03]

LGTM

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.h:31: #include
"core/dom/GetRootNodeOptions.h"
Strictly speaking you don't have to include this in the header,
forward declare here and include in .cpp.

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1271: NodeGetRootNode = 1467,
How about having a separate counter for the call with option?

[tkent, 2016-07-25 04:49:23]

lgtm

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/GetRootNodeOptions.idl (right):

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/GetRootNodeOptions.idl:5: dictionary
GetRootNodeOptions {
Please add a comment on the specification. 
https://dom.spec.whatwg.org/#dictdef-getrootnodeoptions

[hayato, 2016-07-25 04:59:05]

addressed

[hayato, 2016-07-25 04:59:07]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 04:59:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-25 05:03:43]

isherman@, could you review for histograms.xml?

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/GetRootNodeOptions.idl (right):

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/GetRootNodeOptions.idl:5: dictionary
GetRootNodeOptions {
Done

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.h (right):

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.h:31: #include
"core/dom/GetRootNodeOptions.h"
Done

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/2170793002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1271: NodeGetRootNode = 1467,
No, I will not.

[hayato, 2016-07-25 05:04:25]

hayato@chromium.org changed reviewers:
+ isherman@chromium.org

[hayato, 2016-07-25 05:04:26]

Adding isherman@ for histograms.xml. PTAL.

[Ilya Sherman, 2016-07-25 05:28:00]

histograms.xml lgtm

[hayato, 2016-07-25 05:29:49]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-07-25 05:29:56]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-07-25 05:29:56]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2170793002/#ps40001
(title: "addressed")

[commit-bot: I haz the power, 2016-07-25 05:30:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 06:33:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-25 06:35:04]

Description was changed from

==========
Add Node.getRootNode(options)

Intent to Ship and Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MjeLmhOZKXw/zvlyAsvN...

BUG=629739
==========

to

==========
Add Node.getRootNode(options)

Intent to Ship and Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MjeLmhOZKXw/zvlyAsvN...

BUG=629739

Committed: https://crrev.com/9520623861da283533e71d6b7a8babd02675cb0b
Cr-Commit-Position: refs/heads/master@{#407419}
==========

[commit-bot: I haz the power, 2016-07-25 06:35:06]

Patchset 3 (id:??) landed as
https://crrev.com/9520623861da283533e71d6b7a8babd02675cb0b
Cr-Commit-Position: refs/heads/master@{#407419}