Add a timeout to the update event in case page doesn't resolve promise from updateWith

third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentRequestUpdateEvent.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/EventTypeNames.h"
 #include "modules/payments/PaymentUpdater.h"
+#include "platform/testing/UnitTestHelpers.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include <memory>
 
 namespace blink {
 namespace {
 
 class MockPaymentUpdater : public GarbageCollectedFinalized<MockPaymentUpdater>, public PaymentUpdater {
     USING_GARBAGE_COLLECTED_MIXIN(MockPaymentUpdater);
     WTF_MAKE_NONCOPYABLE(MockPaymentUpdater);
 
 public:
     MockPaymentUpdater() {}
     ~MockPaymentUpdater() override {}
 
     MOCK_METHOD1(onUpdatePaymentDetails, void(const ScriptValue& detailsScriptValue));
     MOCK_METHOD1(onUpdatePaymentDetailsFailure, void(const ScriptValue& error));
 
     DEFINE_INLINE_TRACE() {}
 };
 
+ACTION(exitLoop)
+{
+    testing::exitRunLoop();
+}
+
+class MockPaymentUpdaterForTimeout : public GarbageCollectedFinalized<MockPaymentUpdater>, public PaymentUpdater {
+    USING_GARBAGE_COLLECTED_MIXIN(MockPaymentUpdaterForTimeout);
+    WTF_MAKE_NONCOPYABLE(MockPaymentUpdaterForTimeout);
+
+public:
+    MockPaymentUpdaterForTimeout()
+    {
+        ON_CALL(*this, onUpdatePaymentDetailsFailure(::testing::_)).WillByDefault(
+            ::testing::DoAll(exitLoop(), ::testing::Return()));
+    }
+    ~MockPaymentUpdaterForTimeout() override {}
+
+    MOCK_METHOD1(onUpdatePaymentDetails, void(const ScriptValue& detailsScriptValue));
+    MOCK_METHOD1(onUpdatePaymentDetailsFailure, void(const ScriptValue& error));
+
+    DEFINE_INLINE_TRACE() {}
+};
+
+TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsTimeout)
+{
+    V8TestingScope scope;
+    PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create();
+    String errorMessage;
+    MockPaymentUpdaterForTimeout* updater = new MockPaymentUpdaterForTimeout;
+    event->setPaymentDetailsUpdater(updater);
+    event->setEventPhase(Event::CAPTURING_PHASE);
+
+    EXPECT_CALL(*updater, onUpdatePaymentDetails(::testing::_)).Times(0);
+    EXPECT_CALL(*updater, onUpdatePaymentDetailsFailure(::testing::_));
+
+    testing::enterRunLoop();

[please use gerrit instead, 2016/07/21 16:35:24]

This test will run 5 seconds. If I want to change the timeout to 60 seconds,
then this test will run for 1 minute. That's too slow. Instead of running the
loop, you should manually call onTimerFired() from this test. That also
eliminates the need for MockPaymentUpdaterForTimeout.

[pals, 2016/07/22 04:06:19]

Done.

+}
+
 TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsCalled)
 {
     V8TestingScope scope;
     PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create();
     MockPaymentUpdater* updater = new MockPaymentUpdater;
     event->setPaymentDetailsUpdater(updater);
     event->setEventPhase(Event::CAPTURING_PHASE);
     ScriptPromiseResolver* paymentDetails = ScriptPromiseResolver::create(scope.getScriptState());
     event->updateWith(scope.getScriptState(), paymentDetails->promise(), scope.getExceptionState());
     EXPECT_FALSE(scope.getExceptionState().hadException());
 
-    EXPECT_CALL(*updater, onUpdatePaymentDetails(testing::_));
-    EXPECT_CALL(*updater, onUpdatePaymentDetailsFailure(testing::_)).Times(0);
+    EXPECT_CALL(*updater, onUpdatePaymentDetails(::testing::_));
+    EXPECT_CALL(*updater, onUpdatePaymentDetailsFailure(::testing::_)).Times(0);
 
     paymentDetails->resolve("foo");
 }
 
 TEST(PaymentRequestUpdateEventTest, OnUpdatePaymentDetailsFailureCalled)
 {
     V8TestingScope scope;
     PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create(EventTypeNames::shippingaddresschange);
     MockPaymentUpdater* updater = new MockPaymentUpdater;
     event->setPaymentDetailsUpdater(updater);
     event->setEventPhase(Event::CAPTURING_PHASE);
     ScriptPromiseResolver* paymentDetails = ScriptPromiseResolver::create(scope.getScriptState());
     event->updateWith(scope.getScriptState(), paymentDetails->promise(), scope.getExceptionState());
     EXPECT_FALSE(scope.getExceptionState().hadException());
 
-    EXPECT_CALL(*updater, onUpdatePaymentDetails(testing::_)).Times(0);
-    EXPECT_CALL(*updater, onUpdatePaymentDetailsFailure(testing::_));
+    EXPECT_CALL(*updater, onUpdatePaymentDetails(::testing::_)).Times(0);
+    EXPECT_CALL(*updater, onUpdatePaymentDetailsFailure(::testing::_));
 
     paymentDetails->reject("oops");
 }
 
 TEST(PaymentRequestUpdateEventTest, CannotUpdateWithoutDispatching)
 {
     V8TestingScope scope;
     PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create(EventTypeNames::shippingaddresschange);
     event->setPaymentDetailsUpdater(new MockPaymentUpdater);
 
@@ skipping 22 matching lines @@
     V8TestingScope scope;
     PaymentRequestUpdateEvent* event = PaymentRequestUpdateEvent::create(EventTypeNames::shippingaddresschange);
 
     event->updateWith(scope.getScriptState(), ScriptPromiseResolver::create(scope.getScriptState())->promise(), scope.getExceptionState());
 
     EXPECT_FALSE(scope.getExceptionState().hadException());
 }
 
 } // namespace
 } // namespace blink