Add a timeout to the update event in case page doesn't resolve promise from updateWith

third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaymentRequestUpdateEvent_h
 #define PaymentRequestUpdateEvent_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "core/events/Event.h"
 #include "modules/ModulesExport.h"
 #include "modules/payments/PaymentRequestUpdateEventInit.h"
+#include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class ExceptionState;
 class PaymentUpdater;
 class ScriptState;
 
 class MODULES_EXPORT PaymentRequestUpdateEvent final : public Event {
     DEFINE_WRAPPERTYPEINFO();
 
 public:
     ~PaymentRequestUpdateEvent() override;
 
     static PaymentRequestUpdateEvent* create();
     static PaymentRequestUpdateEvent* create(const AtomicString& type, const PaymentRequestUpdateEventInit& = PaymentRequestUpdateEventInit());
 
     void setPaymentDetailsUpdater(PaymentUpdater*);
 
     void updateWith(ScriptState*, ScriptPromise, ExceptionState&);
 
     DECLARE_VIRTUAL_TRACE();
 
+    static const int s_abortTimeout = 5;

[please use gerrit instead, 2016/07/21 16:35:24]

s_waitForUpdateSeconds = 60;

60 seconds seems more reasonable to me. We need to accommodate slow internet
connections as well.

Move this variable into the anonymous namespace in PaymentRequestUpdateEvent.cc,
because it's used only inside of PaymentRequestUpdateEvent.cc.

mek@: In Chromium these variables are formatted kLikeThis. Does Blink follow
different style here?

[pals, 2016/07/22 04:06:19]

Done.

+
 private:
     PaymentRequestUpdateEvent();
     PaymentRequestUpdateEvent(const AtomicString& type, const PaymentRequestUpdateEventInit&);
+    void onTimerFired(Timer<PaymentRequestUpdateEvent>*);

[please use gerrit instead, 2016/07/21 16:35:24]

Make this public and call it from your unit test. This makes your unit test
faster.

[pals, 2016/07/22 04:06:19]

Done.

 
     Member<PaymentUpdater> m_updater;
     bool m_waitForUpdate;
+    Timer<PaymentRequestUpdateEvent> m_abortTimer;
 };
 
 } // namespace blink
 
 #endif // PaymentRequestUpdateEvent_h