Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2170773003: [wasm] Remove the explicit count from WASM_BLOCK and WASM_LOOP macros. (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
Reviewers:
ahaas, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove the explicit count from WASM_BLOCK and WASM_LOOP macros. R=ahaas@chromium.org, rossberg@chromium.org BUG= Committed: https://crrev.com/ff0b6d49ce81af5551c7d7f4fec79d9eae57f99d Cr-Commit-Position: refs/heads/master@{#37939}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -213 lines) Patch
M src/wasm/wasm-macro-gen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 21 chunks +97 lines, -107 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M test/unittests/wasm/ast-decoder-unittest.cc View 14 chunks +47 lines, -54 lines 0 comments Download
M test/unittests/wasm/loop-assignment-analysis-unittest.cc View 7 chunks +16 lines, -17 lines 0 comments Download
M test/unittests/wasm/wasm-macro-gen-unittest.cc View 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
titzer
4 years, 5 months ago (2016-07-21 09:57:37 UTC) #1
rossberg
lgtm
4 years, 5 months ago (2016-07-21 10:43:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170773003/1
4 years, 5 months ago (2016-07-21 10:58:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 11:04:14 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 11:06:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff0b6d49ce81af5551c7d7f4fec79d9eae57f99d
Cr-Commit-Position: refs/heads/master@{#37939}

Powered by Google App Engine
This is Rietveld 408576698