Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2170773002: UnionPay credit card numbers now validated by Luhn checksum. (Closed)

Created:
4 years, 5 months ago by Mikhail Goncharov
Modified:
4 years, 4 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UnionPay credit card numbers now validated by Luhn checksum. In crbug.com/242274 validation of UnionPay credit cards was disabled. The fix was based on Wikipedia article with unreliable source. Here is an edit https://goo.gl/aBmedp changed "unknown" to "no validation" by unregistered user w/o any reference. After a while that was corrected https://goo.gl/phVfrJ I have checked up Amazon.com payment cards form and it accepts only UnionPay cards that pass Luhn checksum. BUG=628518 R=mathp@chromium.org Committed: https://crrev.com/c2e6e3149e3abd4de5b9969c2ece3caa019c3540 Cr-Commit-Position: refs/heads/master@{#409122}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M components/autofill/core/browser/credit_card_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/autofill/core/browser/validation_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mikhail Goncharov
4 years, 5 months ago (2016-07-21 05:18:07 UTC) #1
Mathieu
lgtm, thanks for looking through this!
4 years, 4 months ago (2016-08-01 13:42:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170773002/1
4 years, 4 months ago (2016-08-02 01:45:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 02:27:07 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 02:29:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2e6e3149e3abd4de5b9969c2ece3caa019c3540
Cr-Commit-Position: refs/heads/master@{#409122}

Powered by Google App Engine
This is Rietveld 408576698