Chromium Code Reviews Chromium Code Reviews
Issue 2170753003:
Convert editing/deleting/delete-3928305-fix.html to use w3c test harness (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html |
| diff --git a/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html b/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html |
| index 2d6fdad12dcfbac269e2e8d5f398443c90c2097d..e060ce9dce548674a9c637ee8148f671e003c3d1 100644 |
| --- a/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html |
| +++ b/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html |
| @@ -1,49 +1,12 @@ |
| -<html> |
| -<head> |
| - |
| -<script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> |
| - |
| -<style> |
| -.editing { |
| - border: 2px solid red; |
| - padding: 12px; |
| - font-size: 24px; |
| -} |
| -</style> |
| - |
| +<!doctype html> |
| +<script src="../../resources/testharness.js"></script> |
| +<script src="../../resources/testharnessreport.js"></script> |
| +<script src="../assert_selection.js"></script> |
| <script> |
| - |
| -function editingTest() { |
| - for (i = 0; i < 4; i++) |
| - moveSelectionForwardByCharacterCommand(); |
|
yoichio
2016/07/22 02:09:33
I'm amazed that there are tabs in our code....
yosin_UTC9
2016/07/22 04:19:37
This file was created 12 years ago..
|
| - for (i = 0; i < 3; i++) |
| - extendSelectionForwardByCharacterCommand(); |
| - deleteCommand(); |
| -} |
| - |
| +test(() => { |
| + assert_selection( |
| + '<div contenteditable><div>foo</div>^bar|<div>baz</div></div>', |
| + 'Delete', |
| + '<div contenteditable><div>foo</div><div>|baz</div></div>'); |
| +}, 'selecting an entire line and typing over causes new inserted text at top of document'); |
|
yoichio
2016/07/22 02:09:34
This is the bug description had happened.
Please d
yosin_UTC9
2016/07/22 04:19:37
Done.
BTW, PS#1 doesn't equal to original. :-<
|
| </script> |
| - |
| -<title>Editing Test</title> |
| -</head> |
| -<body contenteditable="true"> |
| - |
| -Should see a blank line between "foo" and "baz" |
| -<div style="height: 24px"></div> |
| - |
| -<div id="root" class="editing"> |
| -<div id="test">foo</div>bar<div>baz</div> |
| - |
| -<!-- |
| - |
| -Fix for this bug: |
| - |
| -<rdar://problem/3928305> selecting an entire line and typing over causes new inserted text at top of document |
| - |
| ---> |
| - |
| -<script> |
| -runEditingTest(); |
| -</script> |
| - |
| -</body> |
| -</html> |
