Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2170753003: Convert editing/deleting/delete-3928305-fix.html to use w3c test harness (Closed)

Created:
4 years, 5 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/delete-3928305-fix.html to use w3c test harness This patch converts "editing/deleting/delete-3928305-fix.html" to use w3c test harness to simplify test files. This patch is a preparation of getting rid of grammar checking feature. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5 Cr-Commit-Position: refs/heads/master@{#407080}

Patch Set 1 : 2016-07-21T18:23:45 #

Total comments: 4

Patch Set 2 : 2016-07-22T13:13:45 #

Messages

Total messages: 18 (11 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-07-21 09:39:01 UTC) #5
yoichio
https://codereview.chromium.org/2170753003/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html File third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html (left): https://codereview.chromium.org/2170753003/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html#oldcode18 third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html:18: moveSelectionForwardByCharacterCommand(); I'm amazed that there are tabs in our ...
4 years, 5 months ago (2016-07-22 02:09:34 UTC) #8
yosin_UTC9
PTAL Fix sample input and expected result. We should have BR in expected result. https://codereview.chromium.org/2170753003/diff/1/third_party/WebKit/LayoutTests/editing/deleting/delete-3928305-fix.html ...
4 years, 5 months ago (2016-07-22 04:19:37 UTC) #11
yoichio
lgtm
4 years, 5 months ago (2016-07-22 04:24:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170753003/20001
4 years, 5 months ago (2016-07-22 04:48:03 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 06:20:20 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 06:21:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b6cfcb832a6ba764490517eb23dd4f616ebd0a5
Cr-Commit-Position: refs/heads/master@{#407080}

Powered by Google App Engine
This is Rietveld 408576698