|
|
Chromium Code Reviews
DescriptionFix flaky content.browser.input.ImeTest#testPasteLongText.
ImeTest#copy() is an asynchronous method. After calling it, we should
wait for the clipboard get updated. Otherwise, we may paste the text
from other tests (like ImeTest#testImePaste) when we call ImeTest#paste().
Before applying this patch, the failure rate is ~12/40 . After that, it
decreases to 0/1000+.
BUG=621046
Committed: https://crrev.com/bd5c4f7c8cfcee76a9212c1c8ab975ea8e81c81b
Cr-Commit-Position: refs/heads/master@{#406801}
Patch Set 1 #Patch Set 2 : change the comment #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yabinh@chromium.org changed reviewers: + changwan@chromium.org
changwan@, can you take a look at this cl?
Description was changed from ========== Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 ========== to ========== Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 ==========
yabinh@chromium.org changed reviewers: + aelias@chromium.org
lgtm, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yabinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yabinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from changwan@chromium.org Link to the patchset: https://codereview.chromium.org/2170753002/#ps20001 (title: "change the comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 ========== to ========== Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 ========== to ========== Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 Committed: https://crrev.com/bd5c4f7c8cfcee76a9212c1c8ab975ea8e81c81b Cr-Commit-Position: refs/heads/master@{#406801} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bd5c4f7c8cfcee76a9212c1c8ab975ea8e81c81b Cr-Commit-Position: refs/heads/master@{#406801} |
