Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2170753002: Fix flaky content.browser.input.ImeTest#testPasteLongText. (Closed)

Created:
4 years, 5 months ago by yabinh
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky content.browser.input.ImeTest#testPasteLongText. ImeTest#copy() is an asynchronous method. After calling it, we should wait for the clipboard get updated. Otherwise, we may paste the text from other tests (like ImeTest#testImePaste) when we call ImeTest#paste(). Before applying this patch, the failure rate is ~12/40 . After that, it decreases to 0/1000+. BUG=621046 Committed: https://crrev.com/bd5c4f7c8cfcee76a9212c1c8ab975ea8e81c81b Cr-Commit-Position: refs/heads/master@{#406801}

Patch Set 1 #

Patch Set 2 : change the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 1 4 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
yabinh
changwan@, can you take a look at this cl?
4 years, 5 months ago (2016-07-21 01:26:37 UTC) #4
Changwan Ryu
lgtm, thanks!
4 years, 5 months ago (2016-07-21 01:33:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170753002/20001
4 years, 5 months ago (2016-07-21 07:54:10 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 07:57:29 UTC) #18
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 07:58:53 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd5c4f7c8cfcee76a9212c1c8ab975ea8e81c81b
Cr-Commit-Position: refs/heads/master@{#406801}

Powered by Google App Engine
This is Rietveld 408576698