[api] Introduce fast instantiations cache

[api] Introduce fast instantiations cache

This CL introduces a new fast flat instantiations cache for the first 1024 object templates.
After that we fall back to the existing slower dictionary cache.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217
Committed: https://crrev.com/f3f738fe8e670f95e003656f671f18c6095533cc
Cr-Commit-Position: refs/heads/master@{#38146}

[Camillo Bruni, 2016-07-21 11:28:17]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 11:28:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-07-21 11:28:43]

The CQ bit was unchecked by cbruni@chromium.org

[Camillo Bruni, 2016-07-21 11:53:04]

cbruni@chromium.org changed reviewers:
+ verwaest@chromium.org

[Camillo Bruni, 2016-07-21 11:53:05]

PTAL first easy step...

[Camillo Bruni, 2016-07-21 11:53:53]

Description was changed from

==========
[api] Introduce fast instantiations cache


BUG=chromium:630217
==========

to

==========
[api] Introduce fast instantiations cache


This CL introduces a new fast instantiations cache for the first 1024 templates.
After that we fall back to the existing slower dictionary cache.

BUG=chromium:630217
==========

[Toon Verwaest, 2016-07-21 12:34:19]

lgtm

[Camillo Bruni, 2016-07-26 09:05:45]

going to drop this CL in favor of:
- directly storing the JSFunction on the FunctionTemplate
- access the boilerplate of the ObjectTemplate from the associated constructor's
shared function info

[Camillo Bruni, 2016-07-26 16:55:34]

Description was changed from

==========
[api] Introduce fast instantiations cache


This CL introduces a new fast instantiations cache for the first 1024 templates.
After that we fall back to the existing slower dictionary cache.

BUG=chromium:630217
==========

to

==========
[api] Introduce fast instantiations cache


This CL introduces a new fast flat instantiations cache for the first 1024
object templates.
After that we fall back to the existing slower dictionary cache.
Additionally we now store the JS-functions directly on the FunctionTemplateInfo
which means that we no longer require a dedicated cache for InstantiateFunction.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217
==========

[Camillo Bruni, 2016-07-26 16:56:15]

cbruni@chromium.org changed reviewers:
+ ahaas@chromium.org, jochen@chromium.org

[Camillo Bruni, 2016-07-26 16:56:23]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 16:56:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:01:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:01:16]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Camillo Bruni, 2016-07-27 14:31:22]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 14:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 14:41:02]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Camillo Bruni, 2016-07-27 15:34:09]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 15:34:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:39:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 15:39:42]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/11314)

[ahaas, 2016-07-27 15:41:24]

On 2016/07/26 at 16:56:16, cbruni wrote:
> 

wasm lgtm

[Camillo Bruni, 2016-07-28 07:12:20]

Description was changed from

==========
[api] Introduce fast instantiations cache


This CL introduces a new fast flat instantiations cache for the first 1024
object templates.
After that we fall back to the existing slower dictionary cache.
Additionally we now store the JS-functions directly on the FunctionTemplateInfo
which means that we no longer require a dedicated cache for InstantiateFunction.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217
==========

to

==========
[api] Introduce fast instantiations cache


This CL introduces a new fast flat instantiations cache for the first 1024
object templates.
After that we fall back to the existing slower dictionary cache.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217
==========

[Camillo Bruni, 2016-07-28 07:32:42]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 07:32:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 07:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 07:34:02]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9824)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5811)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20400)

[Camillo Bruni, 2016-07-28 09:16:31]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 09:16:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 09:37:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 09:37:56]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Camillo Bruni, 2016-07-28 12:00:19]

cbruni@chromium.org changed reviewers:
+ mlippautz@chromium.org

[Camillo Bruni, 2016-07-28 12:00:19]

mlippautz@ PTAL object-stats changes.

[Michael Lippautz, 2016-07-28 15:31:25]

On 2016/07/28 12:00:19, Camillo Bruni wrote:
> mlippautz@ PTAL object-stats changes.

object-stats changes lgtm

[Camillo Bruni, 2016-07-28 16:53:49]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-07-28 16:53:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org, ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2170743003/#ps180001
(title: "fixing uint issue under windows")

[commit-bot: I haz the power, 2016-07-28 16:53:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 17:16:40]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-07-28 17:20:03]

Description was changed from

==========
[api] Introduce fast instantiations cache


This CL introduces a new fast flat instantiations cache for the first 1024
object templates.
After that we fall back to the existing slower dictionary cache.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217
==========

to

==========
[api] Introduce fast instantiations cache

This CL introduces a new fast flat instantiations cache for the first 1024
object templates.
After that we fall back to the existing slower dictionary cache.

Drive-by-fix: de-handlify and clean up some code in api-natives.cc

BUG=chromium:630217

Committed: https://crrev.com/f3f738fe8e670f95e003656f671f18c6095533cc
Cr-Commit-Position: refs/heads/master@{#38146}
==========

[commit-bot: I haz the power, 2016-07-28 17:20:04]

Patchset 10 (id:??) landed as
https://crrev.com/f3f738fe8e670f95e003656f671f18c6095533cc
Cr-Commit-Position: refs/heads/master@{#38146}

[Mircea Trofin, 2016-08-01 23:40:01]

mtrofin@chromium.org changed reviewers:
+ mtrofin@chromium.org

[Mircea Trofin, 2016-08-01 23:40:02]

https://codereview.chromium.org/2170743003/diff/180001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2170743003/diff/180001/src/objects.h#newcode2678
src/objects.h:2678: Handle<T> GetValueChecked(Isolate* isolate, int index)
const;
Why was it necessary to pass the isolate explicitly, rather than getting it from
the FixedArray?

[Camillo Bruni, 2016-08-02 07:27:54]

https://codereview.chromium.org/2170743003/diff/180001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2170743003/diff/180001/src/objects.h#newcode2678
src/objects.h:2678: Handle<T> GetValueChecked(Isolate* isolate, int index)
const;
On 2016/08/01 at 23:40:02, Mircea Trofin wrote:
> Why was it necessary to pass the isolate explicitly, rather than getting it
from the FixedArray?

The calls to GetValueChecked happen in loops and do IsUndefined() internally. 
If you pass in the isolate it actually gets inlined nicely.
I've done a refactoring a while back, replacing all calls of IsUndefined() with
IsUndefined(isolate) yielding some significant speedups in tight loops (kudos to
Toon for discovering this).