Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2170723003: [M53] service worker: Refactor OnNoControllees (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[M53] service worker: Refactor OnNoControllees OnNoControllees doesn't need to unset the flags. * If |is_uninstalling_| is set, the call to Clear() would unset it. * If |should_activate_when_ready_| is set, the call to ActivateWaitingVersion() would unset it. We also change Clear() to unset |should_activate_when_ready_| which makes sense for any callsite of Clear(). Minor simplification in anticipation of changes for https://crbug.com/616331 Refactoring only; no behavior change. BUG=616331 Review-Url: https://codereview.chromium.org/2115393002 Cr-Commit-Position: refs/heads/master@{#403650} (cherry picked from commit 6c74874b9c6969a2afc6f195c96a1a3b15cda890) Committed: https://chromium.googlesource.com/chromium/src/+/09a50f12f80cb14568479cf33b10d55cdb6a54a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/service_worker/service_worker_registration.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
falken
4 years, 5 months ago (2016-07-21 05:49:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09a50f12f80cb14568479cf33b10d55cdb6a54a2.

Powered by Google App Engine
This is Rietveld 408576698