Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2170723002: Converted Observatory vm-nav-menu element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Adding _getBoolAttribute helper method #

Total comments: 4

Patch Set 3 : Added missing space #

Total comments: 2

Patch Set 4 : Merged with master #

Patch Set 5 : Added missing space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -44 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/mocks.dart View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/service_common.dart View 1 chunk +2 lines, -1 line 0 comments Download
A runtime/observatory/lib/src/elements/nav/vm_menu.dart View 1 2 3 4 1 chunk +84 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart View 1 2 3 4 3 chunks +21 lines, -22 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 2 3 4 1 chunk +0 lines, -16 lines 0 comments Download
M runtime/observatory/lib/src/mocks/objects/event.dart View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/mocks/objects/target.dart View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
A runtime/observatory/lib/src/mocks/objects/vm.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/event.dart View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/objects/target.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/vm.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 3 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 3 chunks +8 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.dart View 1 chunk +85 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/vm_menu/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-21 00:59:12 UTC) #2
Cutch
https://codereview.chromium.org/2170723002/diff/1/runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart File runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart (right): https://codereview.chromium.org/2170723002/diff/1/runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart#newcode40 runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart:40: _last = !_isNullOrFalse(getAttribute('last')); I think this needs a better ...
4 years, 5 months ago (2016-07-21 02:30:34 UTC) #3
cbernaschina
https://codereview.chromium.org/2170723002/diff/1/runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart File runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart (right): https://codereview.chromium.org/2170723002/diff/1/runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart#newcode40 runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart:40: _last = !_isNullOrFalse(getAttribute('last')); On 2016/07/21 02:30:33, Cutch wrote: > ...
4 years, 5 months ago (2016-07-21 17:28:16 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-21 18:31:59 UTC) #5
cbernaschina
https://codereview.chromium.org/2170723002/diff/1/runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart File runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart (right): https://codereview.chromium.org/2170723002/diff/1/runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart#newcode40 runtime/observatory/lib/src/elements/nav/vm_menu_wrapper.dart:40: _last = !_isNullOrFalse(getAttribute('last')); On 2016/07/21 02:30:33, Cutch wrote: > ...
4 years, 5 months ago (2016-07-21 18:32:18 UTC) #6
Cutch
LGTM after comments are addressed. https://codereview.chromium.org/2170723002/diff/20001/runtime/observatory/lib/src/elements/nav/vm_menu.dart File runtime/observatory/lib/src/elements/nav/vm_menu.dart (right): https://codereview.chromium.org/2170723002/diff/20001/runtime/observatory/lib/src/elements/nav/vm_menu.dart#newcode77 runtime/observatory/lib/src/elements/nav/vm_menu.dart:77: link: '/inspect?isolateId=${Uri.encodeComponent(isolate.id)}'); please use ...
4 years, 5 months ago (2016-07-22 13:35:44 UTC) #7
cbernaschina
https://codereview.chromium.org/2170723002/diff/20001/runtime/observatory/lib/src/elements/nav/vm_menu.dart File runtime/observatory/lib/src/elements/nav/vm_menu.dart (right): https://codereview.chromium.org/2170723002/diff/20001/runtime/observatory/lib/src/elements/nav/vm_menu.dart#newcode77 runtime/observatory/lib/src/elements/nav/vm_menu.dart:77: link: '/inspect?isolateId=${Uri.encodeComponent(isolate.id)}'); On 2016/07/22 13:35:44, Cutch wrote: > please ...
4 years, 5 months ago (2016-07-22 17:01:23 UTC) #8
rmacnak
lgtm https://chromiumcodereview.appspot.com/2170723002/diff/40001/runtime/observatory/lib/src/mocks/objects/isolate.dart File runtime/observatory/lib/src/mocks/objects/isolate.dart (right): https://chromiumcodereview.appspot.com/2170723002/diff/40001/runtime/observatory/lib/src/mocks/objects/isolate.dart#newcode22 runtime/observatory/lib/src/mocks/objects/isolate.dart:22: const IsolateMock({this.id, this.number, this.name, this.startTime, this.runnable}); Long line
4 years, 5 months ago (2016-07-22 20:24:50 UTC) #9
cbernaschina
https://codereview.chromium.org/2170723002/diff/40001/runtime/observatory/lib/src/mocks/objects/isolate.dart File runtime/observatory/lib/src/mocks/objects/isolate.dart (right): https://codereview.chromium.org/2170723002/diff/40001/runtime/observatory/lib/src/mocks/objects/isolate.dart#newcode22 runtime/observatory/lib/src/mocks/objects/isolate.dart:22: const IsolateMock({this.id, this.number, this.name, this.startTime, this.runnable}); On 2016/07/22 20:24:49, ...
4 years, 5 months ago (2016-07-22 21:05:55 UTC) #10
cbernaschina
4 years, 5 months ago (2016-07-22 22:07:53 UTC) #11
cbernaschina
4 years, 5 months ago (2016-07-22 22:08:24 UTC) #13
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
e71c000ce4f16fdd41019b260e769c637d6ba354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698