Use dom-repeat for addresses, credit cards, and exceptions.

chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Password Settings tests. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 66 matching lines @@
       var node = nodes[index];
       var exception = exceptionList[index];
       assertEquals(exception.exceptionUrl,
                    node.querySelector('#exception').textContent);
       assertEquals(exception.linkUrl,
                    node.querySelector('#exception').href);
     }
   },
 
   /**
+   * Returns all children of an element that has children added by a dom-repeat.
+   * @param {!Element} element
+   * @return {!Array<!Element>}
+   * @private
+   */
+  getDomRepeatChildren_: function(element) {
+    // The template is at the end of the list of children and should be skipped.
+    return Array.prototype.slice.call(element.children, 0, -1);

[michaelpg, 2016/07/26 20:28:39]

Do you think we should assert the last element is actually a <template>? (i'm
not saying we necessarily should)

[hcarmona, 2016/07/26 22:08:15]

Done.

+  },
+
+  /**
    * Skips over the template and returns all visible children of an iron-list.
    * @param {!Element} ironList
    * @return {!Array<!Element>}
    * @private
    */
   getIronListChildren_: function(ironList) {
     return Polymer.dom(ironList).children.filter(function(child, i) {
       return i != 0 && !child.hidden;
     });
   },
@@ skipping 55 matching lines @@
     return false;
   },
 
   /**
    * Allow the iron-list to be sized properly.
    * @param {!Object} passwordsSection
    * @private
    */
   flushPasswordSection_: function(passwordsSection) {
     passwordsSection.$.passwordList.notifyResize();
-    passwordsSection.$.passwordExceptionsList.notifyResize();
     Polymer.dom.flush();
   },
 };
 
 /**
  * This test will validate that the section is loaded with data.
  */
 TEST_F('SettingsPasswordSectionBrowserTest', 'uiTests', function() {
   var self = this;
 
@@ skipping 136 matching lines @@
       Polymer.dom.flush();
 
       var expectedExceptionList = [
         FakeDataMaker.exceptionEntry('docsshow.google.com'),
         FakeDataMaker.exceptionEntry('showmail.com'),
         FakeDataMaker.exceptionEntry('mapsshow.google.com'),
         FakeDataMaker.exceptionEntry('plus.google.comshow'),
       ];
 
       self.validateExceptionList_(
-          self.getIronListChildren_(passwordsSection.$.passwordExceptionsList),
+          self.getDomRepeatChildren_(passwordsSection.$.passwordExceptionsList),
           expectedExceptionList);
     });
 
     test('verifyPasswordExceptions', function() {
       var exceptionList = [
         FakeDataMaker.exceptionEntry('docs.google.com'),
         FakeDataMaker.exceptionEntry('mail.com'),
         FakeDataMaker.exceptionEntry('google.com'),
         FakeDataMaker.exceptionEntry('inbox.google.com'),
         FakeDataMaker.exceptionEntry('maps.google.com'),
         FakeDataMaker.exceptionEntry('plus.google.com'),
       ];
 
       var passwordsSection = self.createPasswordsSection_([], exceptionList);
 
-      // Assert that the data is passed into the iron list. If this fails,
-      // then other expectations will also fail.
-      assertEquals(exceptionList,
-                   passwordsSection.$.passwordExceptionsList.items);
-
       self.validateExceptionList_(
-          self.getIronListChildren_(passwordsSection.$.passwordExceptionsList),
+          self.getDomRepeatChildren_(passwordsSection.$.passwordExceptionsList),
           exceptionList);
     });
 
     // Test verifies that removing an exception will update the elements.
     test('verifyPasswordExceptionRemove', function() {
       var exceptionList = [
         FakeDataMaker.exceptionEntry('docs.google.com'),
         FakeDataMaker.exceptionEntry('mail.com'),
         FakeDataMaker.exceptionEntry('google.com'),
         FakeDataMaker.exceptionEntry('inbox.google.com'),
         FakeDataMaker.exceptionEntry('maps.google.com'),
         FakeDataMaker.exceptionEntry('plus.google.com'),
       ];
 
       var passwordsSection = self.createPasswordsSection_([], exceptionList);
 
       self.validateExceptionList_(
-          self.getIronListChildren_(passwordsSection.$.passwordExceptionsList),
+          self.getDomRepeatChildren_(passwordsSection.$.passwordExceptionsList),
           exceptionList);
 
       // Simulate 'mail.com' being removed from the list.
       passwordsSection.splice('passwordExceptions', 1, 1);
       assertFalse(self.exceptionsListContainsUrl(
             passwordsSection.passwordExceptions, 'mail.com'));
       assertFalse(self.exceptionsListContainsUrl(exceptionList, 'mail.com'));
       self.flushPasswordSection_(passwordsSection);
 
       self.validateExceptionList_(
-          self.getIronListChildren_(passwordsSection.$.passwordExceptionsList),
+          self.getDomRepeatChildren_(passwordsSection.$.passwordExceptionsList),
           exceptionList);
     });
 
     // Test verifies that pressing the 'remove' button will trigger a remove
     // event. Does not actually remove any exceptions.
     test('verifyPasswordExceptionRemoveButton', function(done) {
       var exceptionList = [
         FakeDataMaker.exceptionEntry('docs.google.com'),
         FakeDataMaker.exceptionEntry('mail.com'),
         FakeDataMaker.exceptionEntry('google.com'),
         FakeDataMaker.exceptionEntry('inbox.google.com'),
         FakeDataMaker.exceptionEntry('maps.google.com'),
         FakeDataMaker.exceptionEntry('plus.google.com'),
       ];
 
       var passwordsSection = self.createPasswordsSection_([], exceptionList);
 
       var exceptions =
-          self.getIronListChildren_(passwordsSection.$.passwordExceptionsList);
+          self.getDomRepeatChildren_(passwordsSection.$.passwordExceptionsList);
 
       // The index of the button currently being checked.
       var index = 0;
 
       var clickRemoveButton = function() {
         MockInteractions.tap(
             exceptions[index].querySelector('#removeExceptionButton'));
       };
 
       // Listen for the remove event. If this event isn't received, the test
@@ skipping 41 matching lines @@
         assertEquals(item.loginPair.username, event.detail.username);
         done();
       });
 
       MockInteractions.tap(passwordDialog.$.showPasswordButton);
     });
   });
 
   mocha.run();
 });