Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2170703002: Flip last CrOS builders to GN (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_mac_lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip last CrOS builders to GN. Flip the remaining CrOS builders to GN: - chromium.lkgr: - ChromiumOS ASAN Release - chromium.memory: - Linux Chromium OS ASan LSan Builder - chromium.memory.fyi: - Chromium Linux ChromeOS MSan Builder - tryserver.chromium.linux: - linux_chromium_chromeos_asan_rel_ng R=stevenjb@chromium.org BUG=605732 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_chromeos_asan_rel_ng Committed: https://crrev.com/3a5d7f965cc6130fde6dc45dbd9d9504bfa7400a Cr-Commit-Position: refs/heads/master@{#407045}

Patch Set 1 #

Patch Set 2 : Flip last CrOS builders to GN. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/mb/mb_config.pyl View 1 2 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-21 01:13:02 UTC) #2
stevenjb
lgtm!
4 years, 5 months ago (2016-07-21 16:08:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170703002/40001
4 years, 5 months ago (2016-07-22 00:27:26 UTC) #6
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-22 00:27:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/108623)
4 years, 5 months ago (2016-07-22 02:52:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170703002/40001
4 years, 5 months ago (2016-07-22 03:13:29 UTC) #11
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-22 03:13:31 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-22 03:48:30 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:51:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a5d7f965cc6130fde6dc45dbd9d9504bfa7400a
Cr-Commit-Position: refs/heads/master@{#407045}

Powered by Google App Engine
This is Rietveld 408576698