Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2170673002: buildbucket: add longest_pending_time API (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
phajdan, ghost stip (do not use)
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

buildbucket: add longest_pending_time API CQ will use it to decide whether it should schedule builds now or later R=stip@chromium.org, phajdan@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/infra/+/d9964ad94df66d71b972f9bd2c39a8ccfc739821

Patch Set 1 #

Patch Set 2 : fix datastore index #

Patch Set 3 : builder #

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -2 lines) Patch
M appengine/cr-buildbucket/api.py View 1 2 3 1 chunk +23 lines, -1 line 0 comments Download
M appengine/cr-buildbucket/index.yaml View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M appengine/cr-buildbucket/service.py View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M appengine/cr-buildbucket/test/api_test.py View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M appengine/cr-buildbucket/test/service_test.py View 1 2 2 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 12 (2 generated)
nodir
PTAL
4 years, 5 months ago (2016-07-20 23:26:29 UTC) #1
nodir
On 2016/07/20 23:26:29, nodir wrote: > PTAL deployed https://apis-explorer.appspot.com/apis-explorer/?base=https://4983-bd4f406-tainted-nodir-dot-cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.longest_pending_time?bucket=master.tryserver.infra&_h=2&
4 years, 5 months ago (2016-07-20 23:26:39 UTC) #2
nodir
PTAL I've added "builder" parameter
4 years, 5 months ago (2016-07-21 21:02:18 UTC) #3
ghost stip (do not use)
nice! can I see it in action anywhere?
4 years, 5 months ago (2016-07-21 21:16:51 UTC) #4
nodir
On 2016/07/21 21:16:51, stip wrote: > nice! can I see it in action anywhere? yeah, ...
4 years, 5 months ago (2016-07-21 21:50:25 UTC) #5
ghost stip (do not use)
all builders with pending builds have '0'. is this because the datastore is still populating?
4 years, 5 months ago (2016-07-21 22:49:23 UTC) #6
ghost stip (do not use)
it's working. lgtm!
4 years, 5 months ago (2016-07-21 23:37:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170673002/60001
4 years, 5 months ago (2016-07-22 00:00:50 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/infra/infra/+/d9964ad94df66d71b972f9bd2c39a8ccfc739821
4 years, 5 months ago (2016-07-22 00:16:29 UTC) #11
nodir
4 years, 5 months ago (2016-07-22 17:24:54 UTC) #12
Message was sent while issue was closed. 
btw this is deployed

Powered by Google App Engine
This is Rietveld 408576698