Add more buffer time in HTTPSOCSPVerifyTests.

Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate in OCSP responses generated by minica.py. This gives more wiggle room if there's a time differential between a test bot and a RemoteTestServer, and should help reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an unreachable code path in minica.py.

BUG=630286
Committed: https://crrev.com/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd
Cr-Commit-Position: refs/heads/master@{#407192}

[dadrian, 2016-07-21 21:31:01]

Description was changed from

==========
Fix OCSPVerify tests on Android?

BUG=630286
==========

to

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

BUG=630286
==========

[dadrian, 2016-07-21 21:34:20]

dadrian@google.com changed reviewers:
+ estark@chromium.org, rsleevi@chromium.org, timvolodine@chromium.org

[dadrian, 2016-07-21 21:35:38]

Description was changed from

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

BUG=630286
==========

to

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an
unreachable code path in minica.py.

BUG=630286
==========

[dadrian, 2016-07-22 00:25:32]

This is somewhat a shot in the dark, but I can't imagine any other problem
causing non-deterministic test failures only on Android, given that no edits
were made to platform-specific files.

[timvolodine, 2016-07-22 12:35:49]

you guess is better than mine, lgtm ;)

https://codereview.chromium.org/2170643004/diff/1/net/tools/testserver/minica.py
File net/tools/testserver/minica.py (left):

https://codereview.chromium.org/2170643004/diff/1/net/tools/testserver/minica...
net/tools/testserver/minica.py:301: elif ocsp_date == OCSP_DATE_AFTER_CERT:
also seeing OCSP_DATE_AFTER_CERT in src/net/tools/testserver/testserver.py can
this result in any issues?

[Ryan Sleevi, 2016-07-22 16:58:25]

lgtm w/ the same comment

[dadrian, 2016-07-22 17:02:56]

The CQ bit was checked by dadrian@google.com

[dadrian, 2016-07-22 17:02:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
rsleevi@chromium.org, timvolodine@chromium.org
Link to the patchset: https://codereview.chromium.org/2170643004/#ps20001
(title: "Remove reference to OCSP_DATA_AFTER_CERT")

[commit-bot: I haz the power, 2016-07-22 17:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 17:44:53]

Description was changed from

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an
unreachable code path in minica.py.

BUG=630286
==========

to

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an
unreachable code path in minica.py.

BUG=630286
==========

[commit-bot: I haz the power, 2016-07-22 17:44:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 17:47:14]

Description was changed from

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an
unreachable code path in minica.py.

BUG=630286
==========

to

==========
Add more buffer time in HTTPSOCSPVerifyTests.

This leaves at least 1 day between the value of now() and thisUpdate/nextUpdate
in OCSP responses generated by minica.py. This gives more wiggle room if there's
a time differential between a test bot and a RemoteTestServer, and should help
reduce HTTPSOCSPVerify test flakiness.

This also removes a reference to a non-existant variable in what should be an
unreachable code path in minica.py.

BUG=630286

Committed: https://crrev.com/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd
Cr-Commit-Position: refs/heads/master@{#407192}
==========

[commit-bot: I haz the power, 2016-07-22 17:47:15]

Patchset 2 (id:??) landed as
https://crrev.com/b4f98dd6b994a6510194bd2a85a1d3e6401f6ecd
Cr-Commit-Position: refs/heads/master@{#407192}