Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: components/cronet/tools/cr_cronet.py

Issue 2170643002: [Cronet] Better GN for Cronet on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove spurious period. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/tools/package_ios.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/tools/cr_cronet.py
diff --git a/components/cronet/tools/cr_cronet.py b/components/cronet/tools/cr_cronet.py
index 229154bf340936ba576a2d1dcb8a00f17714cd03..185c43f87f5e4721d01d303b9189720e2e95c82f 100755
--- a/components/cronet/tools/cr_cronet.py
+++ b/components/cronet/tools/cr_cronet.py
@@ -80,6 +80,7 @@ def main():
target_os = 'ios'
test_target = 'cronet_test'
gn_args = 'target_cpu = "x64" '
+ gn_extra = '--ide=xcode'
out_dir_suffix = '-iphonesimulator'
if options.iphoneos:
gn_args = 'target_cpu = "arm64" '
@@ -88,6 +89,7 @@ def main():
target_os = 'android'
test_target = 'cronet_test_instrumentation_apk'
gn_args = 'use_errorprone_java_compiler=true '
+ gn_extra = ''
out_dir_suffix = ''
gyp_defines = 'GYP_DEFINES="OS=' + target_os + ' enable_websockets=0 '+ \
@@ -117,7 +119,7 @@ def main():
if (options.command=='gyp'):
return run (gyp_defines + ' gclient runhooks')
if (options.command=='gn'):
- return run ('gn gen ' + out_dir + ' --args=\'' + gn_args + '\'')
+ return run ('gn gen %s --args=\'%s\' %s' % (out_dir, gn_args, gn_extra))
if (options.command=='sync'):
return run ('git pull --rebase && ' + gyp_defines + ' gclient sync')
if (options.command=='build'):
« no previous file with comments | « no previous file | components/cronet/tools/package_ios.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698