Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2170643002: [Cronet] Better GN for Cronet on iOS. (Closed)

Created:
4 years, 5 months ago by mef
Modified:
4 years, 5 months ago
Reviewers:
kapishnikov, sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Better GN for Cronet on iOS. - Generate xcode project using cr_cronet.py gn - Use fat binary, stripping and dsym support in package_ios.py Committed: https://crrev.com/62368f54556667bcbb75c6f18389bb6d4efbf837 Cr-Commit-Position: refs/heads/master@{#406979}

Patch Set 1 #

Patch Set 2 : Remove spurious period. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M components/cronet/tools/cr_cronet.py View 3 chunks +3 lines, -1 line 0 comments Download
M components/cronet/tools/package_ios.py View 1 1 chunk +29 lines, -42 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mef
PTAL.
4 years, 5 months ago (2016-07-20 22:43:27 UTC) #3
kapishnikov
lgtm
4 years, 5 months ago (2016-07-21 18:14:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170643002/20001
4 years, 5 months ago (2016-07-21 21:58:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 22:50:51 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 22:53:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62368f54556667bcbb75c6f18389bb6d4efbf837
Cr-Commit-Position: refs/heads/master@{#406979}

Powered by Google App Engine
This is Rietveld 408576698