chrome/browser/sync/profile_sync_service_preference_unittest.cc - Issue 217063005: Separate SyncData methods into three groups, local, remote, and common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 217063005: Separate SyncData methods into three groups, local, remote, and common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi

Patch Set: Reorganize Local and Remote based on offline feedback. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/generic_change_processor.cc ('k') | chrome/browser/sync/sessions2/sessions_sync_manager.cc » ('j') | sync/api/sync_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_preference_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_preference_unittest.cc b/chrome/browser/sync/profile_sync_service_preference_unittest.cc

index fbb96c2011a226011f2cf72751f93dfb0ff340e7..1f59d7d83f5fd61b821a27779d752adb46ddc9bc 100644

--- a/chrome/browser/sync/profile_sync_service_preference_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_preference_unittest.cc

@@ -329,7 +329,7 @@ TEST_F(ProfileSyncServicePreferenceTest, CreatePrefSyncData) {

syncer::SyncData sync_data;

EXPECT_TRUE(pref_sync_service_->CreatePrefSyncData(pref->name(),

*pref->GetValue(), &sync_data));

- EXPECT_EQ(std::string(prefs::kHomePage), sync_data.GetTag());

+ EXPECT_EQ(std::string(prefs::kHomePage), sync_data.AsLocal().GetTag());

const sync_pb::PreferenceSpecifics& specifics(sync_data.GetSpecifics().

preference());

EXPECT_EQ(std::string(prefs::kHomePage), specifics.name());

« no previous file with comments | « chrome/browser/sync/glue/generic_change_processor.cc ('k') | chrome/browser/sync/sessions2/sessions_sync_manager.cc » ('j') | sync/api/sync_data.h » ('J')