chrome/browser/extensions/api/storage/settings_sync_unittest.cc - Issue 217063005: Separate SyncData methods into three groups, local, remote, and common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

Issue 217063005: Separate SyncData methods into three groups, local, remote, and common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi

Patch Set: Reorganize Local and Remote based on offline feedback. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

index fa55848057edefcbe9ae1b77727fb7e547dc242a..f7efd58303f8dd5814c18c11d2f0345ba9c54215 100644

--- a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

+++ b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc

@@ -1010,7 +1010,7 @@ TEST_F(ExtensionSettingsSyncTest, FailingGetAllSyncDataDoesntStopSync) {

syncer::SyncDataList all_sync_data =

GetSyncableService(model_type)->GetAllSyncData(model_type);

EXPECT_EQ(1u, all_sync_data.size());

- EXPECT_EQ("good/foo", all_sync_data[0].GetTag());

+ EXPECT_EQ("good/foo", all_sync_data[0].AsLocal().GetTag());

}

testing_factory->GetExisting("bad")->set_error_code(ValueStore::OK);

« no previous file with comments | « no previous file | chrome/browser/extensions/app_sync_bundle.cc » ('j') | sync/api/sync_data.h » ('J')