chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc - Issue 217063005: Separate SyncData methods into three groups, local, remote, and common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

Issue 217063005: Separate SyncData methods into three groups, local, remote, and common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

diff --git a/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc b/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

index 8c00892ce0f64f75719de8464f24a2a24bff1f4e..9e8a91048109f8805f3ef9f4be2aad63f8e35eae 100644

--- a/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

+++ b/chrome/browser/spellchecker/spellcheck_custom_dictionary_unittest.cc

@@ -311,7 +311,7 @@ TEST_F(SpellcheckCustomDictionaryTest,

for (size_t i = 0; i < data.size(); i++) {

EXPECT_TRUE(data[i].GetSpecifics().has_dictionary());

EXPECT_EQ(syncer::DICTIONARY, data[i].GetDataType());

- EXPECT_EQ(words[i], data[i].GetTag());

+ EXPECT_EQ(words[i], data[i].local().GetTag());

EXPECT_EQ(words[i], data[i].GetSpecifics().dictionary().word());

}

« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/sync/glue/favicon_cache_unittest.cc » ('j') | sync/api/sync_data.h » ('J')