Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/api/sync_change.cc

Issue 217063005: Separate SyncData methods into three groups, local, remote, and common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@syncapi
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc ('k') | sync/api/sync_change_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/sync_change.cc
diff --git a/sync/api/sync_change.cc b/sync/api/sync_change.cc
index 8dedd9cb1768fbb0b3f99aebe8ae38e0cad773f7..32b4129a1d859ec64b130a76f3f5d331f832bcff 100644
--- a/sync/api/sync_change.cc
+++ b/sync/api/sync_change.cc
@@ -32,7 +32,7 @@ bool SyncChange::IsValid() const {
return IsRealDataType(sync_data_.GetDataType());
// Local changes must always have a tag and specify a valid datatype.
- if (sync_data_.GetTag().empty() ||
+ if (SyncDataLocal(sync_data_).GetTag().empty() ||
!IsRealDataType(sync_data_.GetDataType())) {
return false;
}
« no previous file with comments | « chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc ('k') | sync/api/sync_change_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698