Separate SyncData methods into three groups, local, remote, and common.

chrome/browser/sync/glue/favicon_cache_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/favicon_cache.h"
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
@@ skipping 202 matching lines @@
   DCHECK_EQ(expected_change_types.size(), expected_icons.size());
   if (change_list.size() != expected_icons.size())
     return testing::AssertionFailure() << "Change list size doesn't match.";
   for (size_t i = 0; i < expected_icons.size(); ++i) {
     TestFaviconData data = BuildFaviconData(expected_icons[i]);
     if (change_list[i].sync_data().GetDataType() != expected_model_type)
       return testing::AssertionFailure() << "Change datatype doesn't match.";
     if (change_list[i].change_type() != expected_change_types[i])
       return testing::AssertionFailure() << "Change type doesn't match.";
     if (change_list[i].change_type() == syncer::SyncChange::ACTION_DELETE) {
-      if (change_list[i].sync_data().GetTag() != data.icon_url.spec())
+      if (change_list[i].sync_data().AsLocal().GetTag() != data.icon_url.spec())
         return testing::AssertionFailure() << "Deletion url does not match.";
     } else {
       testing::AssertionResult compare_result =
           CompareFaviconDataToSpecifics(
               data,
               change_list[i].sync_data().GetSpecifics());
       if (!compare_result)
         return compare_result;
     }
   }
   return testing::AssertionSuccess();
 }
 
 // Helper to extract the favicon id embedded in the tag of a sync
 // change.
 int GetFaviconId(const syncer::SyncChange change) {
-  std::string tag = change.sync_data().GetTag();
+  std::string tag = change.sync_data().AsLocal().GetTag();
   const std::string kPrefix = "http://bla.com/";
   const std::string kSuffix = ".ico";
   if (tag.find(kPrefix) != 0)
     return -1;
   std::string temp = tag.substr(kPrefix.length());
   if (temp.rfind(kSuffix) <= 0)
     return -1;
   temp = temp.substr(0, temp.rfind(kSuffix));
   int result = -1;
   if (!base::StringToInt(temp, &result))
@@ skipping 1088 matching lines @@
     cache()->OnFaviconVisited(test_data.page_url, test_data.icon_url);
     OnCustomFaviconDataAvailable(test_data);
 
     syncer::SyncChangeList changes = processor()->GetAndResetChangeList();
     ASSERT_EQ(4U, changes.size());
     EXPECT_EQ(syncer::SyncChange::ACTION_ADD, changes[0].change_type());
     EXPECT_TRUE(
         CompareFaviconDataToSpecifics(test_data,
                                       changes[0].sync_data().GetSpecifics()));
     EXPECT_EQ(syncer::SyncChange::ACTION_DELETE, changes[1].change_type());
-    EXPECT_EQ(old_favicon.icon_url.spec(), changes[1].sync_data().GetTag());
+    EXPECT_EQ(old_favicon.icon_url.spec(),
+              changes[1].sync_data().AsLocal().GetTag());
 
     EXPECT_EQ(syncer::SyncChange::ACTION_ADD, changes[2].change_type());
     EXPECT_EQ(test_data.icon_url.spec(),
               changes[2].sync_data().GetSpecifics().favicon_tracking().
                   favicon_url());
     EXPECT_NE(changes[2].sync_data().GetSpecifics().favicon_tracking().
                   last_visit_time_ms(), 0);
     EXPECT_EQ(syncer::SyncChange::ACTION_DELETE, changes[3].change_type());
-    EXPECT_EQ(old_favicon.icon_url.spec(), changes[3].sync_data().GetTag());
+    EXPECT_EQ(old_favicon.icon_url.spec(),
+              changes[3].sync_data().AsLocal().GetTag());
   }
 
   EXPECT_EQ(0U, GetTaskCount());
   EXPECT_EQ((unsigned long)kMaxSyncFavicons, GetFaviconCount());
 }
 
 // A full history clear notification should result in all synced favicons being
 // deleted.
 TEST_F(SyncFaviconCacheTest, HistoryFullClear) {
   syncer::SyncDataList initial_image_data, initial_tracking_data;
@@ skipping 458 matching lines @@
   EXPECT_EQ(changes[4].change_type(), syncer::SyncChange::ACTION_ADD);
   EXPECT_EQ(changes[4].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
   EXPECT_EQ(kMaxSyncFavicons, GetFaviconId(changes[4]));
   // Expire tracking for favicon[0].
   EXPECT_EQ(changes[5].change_type(), syncer::SyncChange::ACTION_DELETE);
   EXPECT_EQ(changes[5].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
   EXPECT_EQ(0, GetFaviconId(changes[5]));
 }
 
 }  // namespace browser_sync