Separate SyncData methods into three groups, local, remote, and common.

sync/api/sync_change.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/api/sync_change.h"
 
 #include <ostream>
 
 namespace syncer {
 
@@ skipping 13 matching lines @@
 SyncChange::~SyncChange() {}
 
 bool SyncChange::IsValid() const {
   if (change_type_ == ACTION_INVALID || !sync_data_.IsValid())
     return false;
 
   // Data from the syncer must always have valid specifics.
   if (!sync_data_.IsLocal())
     return IsRealDataType(sync_data_.GetDataType());
 
+  SyncDataLocal sync_data_local(sync_data_);
+
   // Local changes must always have a tag and specify a valid datatype.
-  if (sync_data_.GetTag().empty() ||
+  if (sync_data_local.GetTag().empty() ||

[tim (not reviewing), 2014/03/31 23:24:24]

SyncDataLocal(sync_data_).GetTag() ?

[maniscalco, 2014/03/31 23:33:54]

Done.

       !IsRealDataType(sync_data_.GetDataType())) {
     return false;
   }
 
   // Adds and updates must have a non-unique-title.
   if (change_type_ == ACTION_ADD || change_type_ == ACTION_UPDATE)
     return (!sync_data_.GetTitle().empty());
 
   return true;
 }
@@ skipping 31 matching lines @@
   return "{ " + location_.ToString() + ", changeType: " +
       ChangeTypeToString(change_type_) + ", syncData: " +
       sync_data_.ToString() + "}";
 }
 
 void PrintTo(const SyncChange& sync_change, std::ostream* os) {
   *os << sync_change.ToString();
 }
 
 }  // namespace syncer