Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 2170613002: Fix incorrect use of 'this' in chart-legend. (Closed)

Created:
4 years, 5 months ago by sullivan
Modified:
4 years, 5 months ago
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

Fix incorrect use of 'this' in chart-legend. Unfortunately, this fixes unselected test display in report-page-test but not production. BUG=catapult:#2285 NOTRY=true NOPRESUBMIT=true Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a6054e6e732109bb400e43cd8172ed1c6897e213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M dashboard/dashboard/elements/chart-legend.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
aiolos (Not reviewing)
lgtm
4 years, 5 months ago (2016-07-20 22:07:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170613002/1
4 years, 5 months ago (2016-07-21 01:10:01 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 01:10:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698