Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2170603002:
cc: Fix negative integer overflow in RenderPass serialization code. (Closed)
|
Created:
4 years, 5 months ago by Elliot Glaysher Modified:
4 years, 5 months ago CC:
chromium-reviews, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncc: Fix negative integer overflow in RenderPass serialization code.
It is valid to submit a RenderPass with an empty
|shared_quad_state_list|. We need to deal with this case so that we
don't otherwise take size() - 1, which causes a negative integer overflow.
BUG=626771
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
NOPRESUBMIT=true
Committed: https://crrev.com/878c8a7bea123af169b82bf5de31e8b4356ad47c
Cr-Commit-Position: refs/heads/master@{#406893}
Patch Set 1 #Patch Set 2 : Add test. #
Messages
Total messages: 25 (14 generated)
Description was changed from ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 ========== to ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ==========
The CQ bit was checked by erg@chromium.org to run a CQ dry run
erg@chromium.org changed reviewers: + dcheng@chromium.org, fsamuel@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The fix looks good but I think we need a unit test that submits an empty CompositorFrame and/or an empty RenderPass.
Added test, and ensured that it failed when I commented out the fix.
The CQ bit was checked by erg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
LGTM
The CQ bit was checked by erg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel ========== to ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel NOPRESUBMIT=true ==========
(Skipping presubmit on next run since the CQ isn't recognizing dcheng's lgtm for some reason.)
The CQ bit was checked by erg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel NOPRESUBMIT=true ========== to ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel NOPRESUBMIT=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel NOPRESUBMIT=true ========== to ========== cc: Fix negative integer overflow in RenderPass serialization code. It is valid to submit a RenderPass with an empty |shared_quad_state_list|. We need to deal with this case so that we don't otherwise take size() - 1, which causes a negative integer overflow. BUG=626771 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel NOPRESUBMIT=true Committed: https://crrev.com/878c8a7bea123af169b82bf5de31e8b4356ad47c Cr-Commit-Position: refs/heads/master@{#406893} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/878c8a7bea123af169b82bf5de31e8b4356ad47c Cr-Commit-Position: refs/heads/master@{#406893} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
