Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: chrome/test/data/webui/settings/settings_page_browsertest.js

Issue 2170583002: MD Settings: fix route query in tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_page_browsertest.js
diff --git a/chrome/test/data/webui/settings/settings_page_browsertest.js b/chrome/test/data/webui/settings/settings_page_browsertest.js
index f7de861327fabcd1919cfa663e8a4ab3845305b9..08c096ec6c508a383520a59340e0e7159e71837a 100644
--- a/chrome/test/data/webui/settings/settings_page_browsertest.js
+++ b/chrome/test/data/webui/settings/settings_page_browsertest.js
@@ -86,8 +86,8 @@ SettingsPageBrowserTest.prototype = {
* @return {boolean} True if the router's state is a root page, e.g. Basic.
*/
isAtRoot: function() {
- var router = this.getRouter();
- return router.section == '' && router.subpage.length == 0;
+ var route = this.getRouter().currentRoute;
+ return route.section == '' && route.subpage.length == 0;
tommycli 2016/07/20 21:33:02 Also perhaps it would be even clearer to check ro
},
/** Navigates to the current root page, e.g. Basic. */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698