MD Settings: fix route query in tests

chrome/test/data/webui/settings/languages_page_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for settings-languages-page. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 48 matching lines @@
       Polymer.dom.flush();
 
       languagesSection = this.getSection(advanced, 'languages');
       assertTrue(!!languagesSection);
       languagesPage = languagesSection.querySelector('settings-languages-page');
       assertTrue(!!languagesPage);
 
       return LanguageHelperImpl.getInstance().whenReady();
     }.bind(this));
 
     teardown(function(done) {

[tommycli, 2016/07/20 22:16:15]

This teardown is needed to navigate back after each test? Otherwise it's stuck
on the subpage after each test right?

[michaelpg, 2016/07/20 22:40:08]

yes, adjusted the comment

-      if (this.isAtRoot())
-        return done();
-      this.backToRoot();
-      setTimeout(done);
-    }.bind(this));
+      if (advanced.currentRoute.subpage.length == 0) {
+        done();
+      } else {
+        // Close the section.
+        advanced.currentRoute = {
+          page: 'advanced',
+          section: '',
+          subpage: [],
+        };
+        setTimeout(done);

[tommycli, 2016/07/20 22:16:15]

Does advanced.async make more sense?

[michaelpg, 2016/07/20 22:40:08]

No, the tests can become flaky that way. I think we need the timeout for the
animations (which are disabled but still require a new event loop)

+      }
+    });
 
     test('manage languages', function() {
       var manageLanguagesButton =
           languagesPage.$.languagesCollapse.querySelector(
               '.list-button:last-of-type');
       MockInteractions.tap(manageLanguagesButton);
       assertTrue(!!languagesPage.$$('settings-manage-languages-page'));
     });
 
     test('language detail', function() {
@@ skipping 35 matching lines @@
         assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
       }
     });
   }.bind(this));
 
   // TODO(michaelpg): Test more aspects of the languages UI.
 
   // Run all registered tests.
   mocha.run();
 });