MD Settings: fix route query in tests

MD Settings: fix route query in tests

This was never correct AFAICT, which had a minor impact on the languages page test.

BUG=none
TEST=SettingsLanguagesPageBrowserTest.LanguagesPage
R=tommycli@chromium.org

Committed: https://crrev.com/f56c5224ad496a99d3d66a055f9fa42eb9f8af50
Cr-Commit-Position: refs/heads/master@{#406714}

[michaelpg, 2016-07-20 21:30:06]

Tommy, I didn't see anything else that looks blatantly wrong, but something to
keep an eye on (if you aren't yet) with the routing changes.

[michaelpg, 2016-07-20 21:30:37]

On 2016/07/20 21:30:06, michaelpg wrote:
> Tommy, I didn't see anything else that looks blatantly wrong, but something to
> keep an eye on (if you aren't yet) with the routing changes.

(and "blatantly wrong" wasn't meant to sound mean. I think I wrote this,
anyway!)

[tommycli, 2016-07-20 21:33:02]

lgtm

https://codereview.chromium.org/2170583002/diff/1/chrome/test/data/webui/sett...
File chrome/test/data/webui/settings/settings_page_browsertest.js (right):

https://codereview.chromium.org/2170583002/diff/1/chrome/test/data/webui/sett...
chrome/test/data/webui/settings/settings_page_browsertest.js:90: return
route.section == '' && route.subpage.length == 0;
Also perhaps it would be even clearer to check

route == settings.Route.BASIC || route == settings.Route.ADVANCED.

[michaelpg, 2016-07-20 21:57:39]

PTAL. Soon everything will be using settings.Route and this will get much
easier, so we really don't need generalized functions in SettingsPageBrowserTest
for this.

[tommycli, 2016-07-20 22:16:16]

https://codereview.chromium.org/2170583002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/languages_page_browsertest.js (right):

https://codereview.chromium.org/2170583002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/languages_page_browsertest.js:69:
teardown(function(done) {
This teardown is needed to navigate back after each test? Otherwise it's stuck
on the subpage after each test right?

https://codereview.chromium.org/2170583002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/languages_page_browsertest.js:79:
setTimeout(done);
Does advanced.async make more sense?

[michaelpg, 2016-07-20 22:39:51]

The CQ bit was checked by michaelpg@chromium.org to run a CQ dry run

[michaelpg, 2016-07-20 22:40:08]

https://codereview.chromium.org/2170583002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/languages_page_browsertest.js (right):

https://codereview.chromium.org/2170583002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/languages_page_browsertest.js:69:
teardown(function(done) {
On 2016/07/20 22:16:15, tommycli wrote:
> This teardown is needed to navigate back after each test? Otherwise it's stuck
> on the subpage after each test right?

yes, adjusted the comment

https://codereview.chromium.org/2170583002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/languages_page_browsertest.js:79:
setTimeout(done);
On 2016/07/20 22:16:15, tommycli wrote:
> Does advanced.async make more sense?

No, the tests can become flaky that way. I think we need the timeout for the
animations (which are disabled but still require a new event loop)

[commit-bot: I haz the power, 2016-07-20 22:40:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-07-20 22:55:49]

lgtm thanks

[commit-bot: I haz the power, 2016-07-20 23:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:27:41]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-07-20 23:36:21]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:43:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 23:44:53]

Description was changed from

==========
MD Settings: fix route query in tests

This was never correct AFAICT, which had a minor impact on the languages page
test.

BUG=none
TEST=SettingsLanguagesPageBrowserTest.LanguagesPage
R=tommycli@chromium.org
==========

to

==========
MD Settings: fix route query in tests

This was never correct AFAICT, which had a minor impact on the languages page
test.

BUG=none
TEST=SettingsLanguagesPageBrowserTest.LanguagesPage
R=tommycli@chromium.org

Committed: https://crrev.com/f56c5224ad496a99d3d66a055f9fa42eb9f8af50
Cr-Commit-Position: refs/heads/master@{#406714}
==========

[commit-bot: I haz the power, 2016-07-20 23:44:54]

Patchset 3 (id:??) landed as
https://crrev.com/f56c5224ad496a99d3d66a055f9fa42eb9f8af50
Cr-Commit-Position: refs/heads/master@{#406714}