[css-flexbox] Some more code refactoring

[css-flexbox] Some more code refactoring

Add a constructFlexItem function that does the computations
for creating a FlexItem, and returns it. Also add a couple more
cached pieces of data to FlexItem which simplifies code in
a couple of places.

constructFlexItem will also be useful for implementing the
new intrinsic size algorithm.

R=eae@chromium.org,dgrogan@chromium.org
TEST=n/a, no change in behavior

Committed: https://crrev.com/3359cdec92d2eb3b61738313ecdae2d60de2e160
Cr-Commit-Position: refs/heads/master@{#407241}

[cbiesinger, 2016-07-20 18:59:18]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 18:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:03:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:03:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[cbiesinger, 2016-07-20 21:08:09]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:08:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 22:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 22:25:20]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2016-07-22 18:37:16]

Emil, ping?

[eae, 2016-07-22 18:37:52]

LGTM

[eae, 2016-07-22 18:38:24]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-07-22 18:39:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 20:13:28]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 20:16:30]

Description was changed from

==========
[css-flexbox] Some more code refactoring

Add a constructFlexItem function that does the computations
for creating a FlexItem, and returns it. Also add a couple more
cached pieces of data to FlexItem which simplifies code in
a couple of places.

constructFlexItem will also be useful for implementing the
new intrinsic size algorithm.

R=eae@chromium.org,dgrogan@chromium.org
TEST=n/a, no change in behavior
==========

to

==========
[css-flexbox] Some more code refactoring

Add a constructFlexItem function that does the computations
for creating a FlexItem, and returns it. Also add a couple more
cached pieces of data to FlexItem which simplifies code in
a couple of places.

constructFlexItem will also be useful for implementing the
new intrinsic size algorithm.

R=eae@chromium.org,dgrogan@chromium.org
TEST=n/a, no change in behavior

Committed: https://crrev.com/3359cdec92d2eb3b61738313ecdae2d60de2e160
Cr-Commit-Position: refs/heads/master@{#407241}
==========

[commit-bot: I haz the power, 2016-07-22 20:16:31]

Patchset 1 (id:??) landed as
https://crrev.com/3359cdec92d2eb3b61738313ecdae2d60de2e160
Cr-Commit-Position: refs/heads/master@{#407241}